Skip to content

Update pipeline findings description and report label

Lorenz van Herwaarden requested to merge update-pipeline-report-text into master

What does this MR do and why?

Related #436975 (closed)

This updates the description of the pipeline findings page and the label of the button in the security report mr widget which links to that page.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
mr-widget-before mr-widget-after
pipeline-before pipeline-after

How to set up and validate locally

Prerequisites

  1. You need an EE license
  2. You need to have runners enabled (See $2408961 for setting up a runner)
  3. Import https://gitlab.com/gitlab-org/govern/demos/sandbox/minac/test-remediations
  4. Do not run a pipeline yet on master!
  5. In the imported test-remediations project
    1. go to reports/sast.json and remove both entries in vulnerabilities, leaving effectively an empty array
    2. commit and push this to master
    3. now, in reports/sast.json, add the removed vulnerabilities back again, but commit and push to a new branch, and create a merge request.

Validate

  1. In the MR, validate that the security scanning widget's button on the right side is now called "View all pipeline findings"
  2. Click on the button. Validate that the page description on the pipeline security page is "Results show vulnerability findings from the latest successful pipeline." and that the pipeline word links to the same help page as the help icon did before.
Edited by Lorenz van Herwaarden

Merge request reports