Stop preloading the binary call for blobs
What does this MR do and why?
When we are stitching the blobs, the current behaviour is to preload the binary
call, however, when we do this we will be retrieving the diff each time. It is better to only set binary
if needed later on, per object.
To Test:
- Turn on
stop_precalling_binary_for_blobs
feature flag - Create an MR that contains a binary file + other files
- Ensure the MR diff works as expected
Merge request reports
Activity
assigned to @marc_shaw
- Resolved by Marc Shaw
added groupcode review label
added devopscreate sectiondev labels
added backend maintenanceperformance labels and removed devopscreate sectiondev labels
added typemaintenance label
added devopscreate sectiondev labels
added 1 commit
- 0eb628ab - Stop preloading binary call when stitching blobs
added pipeline:run-all-e2e label
- A deleted user
added feature flag label
1 Warning This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @imand3r
(UTC-8, 9 hours behind author)
@dstull
(UTC-5, 6 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @imand3r
(UTC-8, 9 hours behind author)
@dstull
(UTC-5, 6 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Userchanged milestone to %16.9
requested review from @patrickbajao
- Resolved by Marc Shaw
Ahoy hoy @patrickbajao
This is the change pulled from the other MR.
Do you mind taking the first review here?