Skip to content
Snippets Groups Projects

Stop preloading the binary call for blobs

Merged Marc Shaw requested to merge stop_preloading_binary_call_for_blobs into master

What does this MR do and why?

When we are stitching the blobs, the current behaviour is to preload the binary call, however, when we do this we will be retrieving the diff each time. It is better to only set binary if needed later on, per object.

#424140 (closed)

To Test:

  • Turn on stop_precalling_binary_for_blobs feature flag
  • Create an MR that contains a binary file + other files
  • Ensure the MR diff works as expected
Edited by Marc Shaw

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marc Shaw resolved all threads

    resolved all threads

  • Marc Shaw added 1 commit
  • Marc Shaw added 1 commit

    added 1 commit

    • 0eb628ab - Stop preloading binary call when stitching blobs

    Compare with previous version

  • Marc Shaw changed the description

    changed the description

  • A deleted user added feature flag label

    added feature flag label

  • 1 Warning
    :warning: This merge request does not refer to an existing milestone.
    1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend @imand3r profile link current availability (UTC-8, 9 hours behind author) @dstull profile link current availability (UTC-5, 6 hours behind author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • 1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend @imand3r profile link current availability (UTC-8, 9 hours behind author) @dstull profile link current availability (UTC-5, 6 hours behind author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • Marc Shaw changed milestone to %16.9

    changed milestone to %16.9

  • Marc Shaw requested review from @patrickbajao

    requested review from @patrickbajao

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading