Add geo_pipeline_replication feature flag

What does this MR do and why?

Adds a feature flag so pipeline ref replication can be disabled.

My hypothesis is that the logic is unneeded. Therefore we can disable it in staging-ref and Dedicated (which should immediately alleviate https://gitlab.com/gitlab-com/gl-infra/gitlab-dedicated/incident-management/-/issues/128).

We should also confirm that it is not needed in combination with https://docs.gitlab.com/ee/administration/geo/secondary_proxy/runners.html.

If those tests show that it is not needed, then we can delete the code.

#438632 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

This MR does not cause a behavior change. You must disable the FF in order to cause a behavior change. The following steps are how we can validate the hypothesis. I have SSL set up locally and use Podman since I can't use Docker, and both things combined make it really hard to set up a Runner locally.

1. Set up Geo
2. Enable secondary runners
3. Set up a Runner with the secondary Geo site
4. Push changes to a repo
5. Confirm that the pipeline works
6. In rails console disable the feature flag

   Feature.disable(:geo_pipeline_replication)

7. Push changes to a repo
8. Confirm that the pipeline works

changed milestone to %16.9

added bugfunctional groupgeo severity3 typebug labels

assigned to @mkozono

added devopssystems sectioncore platform labels

changed the description

@ibaum WDYT? In my testing, I don't see pipeline ref created events without project repo update events preceding. Seems ok to start the process of removal and help Dedicated resolve Gitaly alerts.

requested review from @ibaum

added backend feature flag labels

	1 Warning
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.

	1 Message
	CHANGELOG missing: If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	@joseph (UTC+0, 10 hours ahead of author)	@georgekoltsov (UTC+0, 10 hours ahead of author)

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

• ab383bc7 - Add geo_pipeline_replication feature flag

Compare with previous version

resolved all threads

added 1 commit

• ba82e978 - Add MR URL to feature flag

Compare with previous version

added 1 commit

• 29fbe5d3 - Add geo_pipeline_replication feature flag

Compare with previous version

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@9b4cfaca

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 11babd74

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 8      | 0      | 3       | 0     | 11    | ✅     |
| Data Stores | 2      | 0      | 0       | 0     | 2     | ✅     |
| Plan        | 4      | 0      | 0       | 0     | 4     | ✅     |
| Monitor     | 4      | 0      | 0       | 0     | 4     | ✅     |
| Govern      | 3      | 0      | 0       | 0     | 3     | ✅     |
| Package     | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 21     | 0      | 4       | 0     | 25    | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 11babd74

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 16     | 0      | 6       | 0     | 22    | ✅     |
| Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
| Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
| Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 42     | 0      | 8       | 0     | 50    | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

changed the description

mentioned in issue #438632 (closed)

This all makes sense to me @mkozono. I'll pass to @dbalexandre for maintainer review as this is fairly Geo specific.

approved this merge request

@ibaum, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

added pipeline:mr-approved label

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@4f08ba7f

added 1 commit

• 11babd74 - Update feature flag definition

Compare with previous version

requested review from @dbalexandre

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@5a0c9ab3

resolved all threads

approved this merge request

enabled an automatic merge when all merge checks for 11babd74 pass

merged

mentioned in commit f20c92a5

added workflowstaging-canary label

@mkozono This merge request was deployed to the workflowstaging-canary environment. You may want to delete the associated feature flag record on this environment with /chatops run feature delete geo_pipeline_replication --dev --pre --staging.

This message was generated automatically. You're welcome to improve it.

This merge request was deployed to the workflowcanary environment. You may want to delete the associated feature flag record on this environment with /chatops run feature delete geo_pipeline_replication --dev --pre --production.

This message was generated automatically. You're welcome to improve it.

This merge request was deployed to the workflowproduction environment. You may want to delete the associated feature flag record on this environment with /chatops run feature delete geo_pipeline_replication --dev --pre --production.

This message was generated automatically. You're welcome to improve it.

This merge request was deployed to the workflowstaging environment. You may want to delete the associated feature flag record on this environment with /chatops run feature delete geo_pipeline_replication --dev --pre --staging.

This message was generated automatically. You're welcome to improve it.

added workflowcanary label and removed workflowstaging-canary label

added workflowproduction label and removed workflowcanary label

added workflowstaging label and removed workflowproduction label

added releasedcandidate label