Skip to content

Set modal title to finding title

Lorenz van Herwaarden requested to merge add-finding-title-modal-title into master

What does this MR do and why?

There is a console warning for the vulnerability finding modal because it does not have a title. This MR sets the modal title to the same as its visible heading (and the same as the modal title in the old finding modal), namely the finding title if it exists, otherwise a backup 'Error' message.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Prerequisites

  1. You need an EE license
  2. You need to have runners enabled (See $2408961 for setting up a runner)
  3. Import https://gitlab.com/gitlab-examples/security/security-reports
  4. Run a pipeline on master

Validate

  1. Go to the latest pipeline security tab and select one of the findings
  2. Validate in the console that the div with id "security-finding-modal" has an attribute aria-label="<finding title>"

Merge request reports