E2E test: make add and delete ssh key spec idempotent
What does this MR do and why?
In #438605 (closed), the delete
spec failed since the add
test failed.
The tests are currently non-idempotent, this MR separates the delete
spec so it does its' own setup.
How to set up and validate locally
Run together:
QA_LOG_LEVEL=DEBUG QA_GITLAB_URL=http://192.168.4.31:3000 bundle exec rspec qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb
Run separately:
QA_LOG_LEVEL=DEBUG QA_GITLAB_URL=http://192.168.4.31:3000 bundle exec rspec qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb:12
QA_LOG_LEVEL=DEBUG QA_GITLAB_URL=http://192.168.4.31:3000 bundle exec rspec qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb:21
Merge request reports
Activity
assigned to @jay_mccure
mentioned in issue #438605 (closed)
- A deleted user
added QA label
1 Warning This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer QA @dchevalier2
(UTC-5, 15 hours behind author)
@mlapierre
(UTC+11, 1 hour ahead of author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@jay_mccure - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added 1 commit
- 02ab50d6 - E2E test: separate add and delete ssh key specs
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 02ab50d6expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 2 | 0 | 0 | 0 | 2 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 2 | 0 | 0 | 0 | 2 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 02ab50d6expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 0 | 0 | 8 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 8 | 0 | 0 | 0 | 8 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded maintenancerefactor label
added typemaintenance label
- Resolved by Mark Lapierre
Hi @dchevalier2, do you mind reviewing this change? Thank you!
requested review from @dchevalier2
requested review from @mlapierre and removed review request for @dchevalier2