Skip to content

Move unprotected_scoped_variables to bridge class

Dmytro Biryukov requested to merge dbiryukov_follow_up_move_scoped_variables_into_the_bridge_mr-431835 into master

Related to a follow-up issues:

  1. #431835 - Move unprotected_scoped_variables to bridge class
  2. #431834 (closed) - Rename unprotected_scoped_variables
  3. #431836 (closed) - Skip this issue as we still need this condition to handle on unprotected branches a situation when we have to not pass protected variables downstream - (expose_protected_project_variables? && expose_protected_group_variables?)

Original issue: https://gitlab.com/gitlab-org/gitlab/-/issues/419844

Original MR: !135899 (merged)

What does this MR do and why?

This is a follow-up issue to bridge class

  1. Move unprotected_scoped_variables to bridge class
  2. Rename unprotected_scoped_variables to conditional_scoped_variables
  3. Remove redundant condition - (expose_protected_project_variables? && expose_protected_group_variables?)

Move unprotected_scoped_variables to bridge class

Changelog: changed

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Dmytro Biryukov

Merge request reports