Follow-up from "Exclude protected variables from multi-project pipeline bridge triggers"
The following discussion from !135899 (merged) should be addressed:
-
@alberts-gitlab started a discussion: What do you think of moving this method to within
Ci::Bridge
? It isn't needed byCi::Build
and we are also only testing it withinbridge_spec.rb
. We don't need to expose methods to other classes unnecessarily.If we move this into
Ci::Bridge
, we may be able to simplify the method signature.bridge_variables = if ::Feature.disabled?(:exclude_protected_variables_from_multi_project_pipeline_triggers, project) scoped_variables else scoped_bridge_variables end # ... def scoped_bridge_variables track_duration do pipeline .variables_builder .unprotected_scoped_variables( self, expose_project_variables: expose_project_variables, expose_group_variables: expose_group_variables, environment: expanded_environment_name, dependencies: true ) end end
This page may contain information related to upcoming products, features and functionality. It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes. Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.