Update advice for QA selectors in rubocop output

What does this MR do and why?

Update advice for QA selectors in rubocop output:

• Update advice given to current practice of using data-testid vs the deprecated data-qa-selector

• Refs: gitlab-org/quality/quality-engineering/team-tasks#1735

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.