Skip to content
Snippets Groups Projects

Migrate deprecated sorting-item vue component in sort_dropdown

Merged Taras Tadai requested to merge 437931-migrate-sorting-item-in-sort-dropdown into master

What does this MR do and why?

Removed gl-sorting-item in app/assets/javascripts/members/components/filter_sort/sort_dropdown.vue as it's deprecated. New way to use it is to pass :sort-options=.

It's a part of Pajamas adoption project

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
members_filter_sort_old members_filter_sort_new

How to set up and validate locally

  1. Open any Group -> Manage -> Members
  2. Use sorting component (see screenshots)

Related to #437931 (closed)

Merge request reports

Merged results pipeline #1141942475 canceled

Pipeline: E2E Omnibus GitLab EE

#1142033005

    Pipeline: GitLab

    #1141950029

      Pipeline: E2E GDK

      #1141949864

        +2

        Merged results pipeline canceled for 53e4d57a

        Test coverage 81.48% (16.68%) from 2 jobs

        Merged by Illya KlymovIllya Klymov 1 year ago (Jan 22, 2024 4:13pm UTC)

        Loading

        Pipeline #1146932196 passed

        Pipeline passed for 3134b20f on master

        Test coverage 64.89% (16.68%) from 2 jobs
        10 environments impacted.

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
        Please register or sign in to reply
        Loading