Migrate deprecated sorting-item vue component in sort_dropdown
What does this MR do and why?
Removed gl-sorting-item
in app/assets/javascripts/members/components/filter_sort/sort_dropdown.vue
as it's deprecated. New way to use it is to pass :sort-options=
.
It's a part of Pajamas adoption project
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Open any Group -> Manage -> Members
- Use sorting component (see screenshots)
Related to #437931 (closed)
Merge request reports
Activity
added component:sorting devopsgovern groupauthentication pajamasintegrate sectionsec severity4 typemaintenance workflowin dev + 1 deleted label
assigned to @ttaday-ext
- A deleted user
added frontend label
2 Warnings b7cd9f93: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend @viktomas
(UTC+1)
@xanf
(UTC+2)
test for spec/features/*
@hmuralidhar
(UTC+11)
Maintainer review is optional for test for spec/features/*
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 0417b074 and b7cd9f93
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.15 MB 4.15 MB - -0.0 % mainChunk 3.12 MB 3.12 MB - 0.0 %
Note: We do not have exact data for 0417b074. So we have used data from: 1a6b13a0.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost Userrequested review from @viktomas
- Resolved by Illya Klymov
@viktomas can you please review this MR? Thank you!
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for b7cd9f93expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 51 | 0 | 3 | 0 | 54 | ✅ | | Govern | 64 | 0 | 3 | 0 | 67 | ✅ | | Package | 15 | 0 | 1 | 0 | 16 | ✅ | | Verify | 29 | 0 | 2 | 0 | 31 | ✅ | | Create | 45 | 0 | 17 | 0 | 62 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Data Stores | 20 | 0 | 3 | 0 | 23 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 238 | 0 | 30 | 0 | 268 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded 1 commit
- b7cd9f93 - Migrate deprecated sorting-item vue component
- Resolved by Illya Klymov
@viktomas
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, please start a new pipeline before merging.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
changed milestone to %16.9
enabled an automatic merge when all merge checks for b7cd9f93 pass
1 Warning b7cd9f93: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend @lorenzvanherwaarden
(UTC+1)
@mlunoe
(UTC+1)
test for spec/features/*
@hmuralidhar
(UTC+11)
Maintainer review is optional for test for spec/features/*
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 7e35389b and b7cd9f93
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.16 MB 4.16 MB - -0.0 % mainChunk 3.12 MB 3.12 MB - 0.0 %
Note: We do not have exact data for 7e35389b. So we have used data from: d9a4f58d.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger