Skip to content
Snippets Groups Projects

Add sharding keys for feature category container_registry

All threads resolved!

These tables have been identified as cell local tables.

All cell local tables require a sharding key.

A sharding key has been automatically selected for these tables. The sharding key was chosen because it is a NOT NULL column referencing either projects or namespaces.

Please confirm that this table should indeed be cell local, and that the selected column is an appropriate sharding key.

When updating the gitlab_schema we have also added allow_cross_joins, allow_cross_transactions and allow_cross_foreign_keys. You can read about this in https://docs.gitlab.com/ee/development/database/multiple_databases.html but basically for now we want to ignore any of these violations and just classify the tables that belong to gitlab_main_cell. In future we'll remove these allow_... statements so that we can fix these violations.

If you have any questions or concerns, reach out to @tigerwnz or @DylanGriffith.

This merge request was created using the gitlab-housekeeper gem.

Edited by Dylan Griffith

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Fernandez removed review request for @10io

    removed review request for @10io

  • Dylan Griffith requested review from @10io

    requested review from @10io

  • David Fernandez approved this merge request

    approved this merge request

  • David Fernandez requested review from @tigerwnz and removed review request for @10io

    requested review from @tigerwnz and removed review request for @10io

  • Tiger Watson approved this merge request

    approved this merge request

  • Tiger Watson changed milestone to %16.9

    changed milestone to %16.9

  • added databaseapproved label and removed databasereview pending label

  • Tiger Watson resolved all threads

    resolved all threads

  • Tiger Watson enabled an automatic merge when all merge checks for 970eb051 pass

    enabled an automatic merge when all merge checks for 970eb051 pass

  • merged

  • Hello @DylanGriffith :wave:

    The database team is looking for ways to improve the database review process and we would love your help!

    If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

    @gitlab-org/database-team

    And someone will be by shortly!

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Tiger Watson mentioned in commit 52edbf6a

    mentioned in commit 52edbf6a

  • added workflowstaging label and removed workflowcanary label

  • Adie (she/her) mentioned in merge request !142502 (merged)

    mentioned in merge request !142502 (merged)

  • mentioned in issue #434985 (closed)

  • Please register or sign in to reply
    Loading