Clean up FF scan_result_any_merge_request
What does this MR do and why?
This MR removes feature flag scan_result_any_merge_request
which has been enabled by default in %16.7 in Enable scan_result_any_merge_request by default (!136298 - merged).
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
- In rails console, make sure to disable the feature flag in case it was enabled before
Feature.disable(:scan_result_any_merge_request)
- Visit Secure -> Policies and create a new Scan Result Policy
- Ensure that "Any merge request" rule type can be selected and there are no errors in the console
- Save a policy
- Edit the policy
- Ensure that "Any merge request" rule type is pre-selected and there are no errors
- Try also various combinations with the related feature flags:
scan_result_policies_block_force_push
scan_result_policies_block_unprotecting_branches
Related to #432127 (closed)
Merge request reports
Activity
changed milestone to %16.8
assigned to @mcavoj
- A deleted user
added documentation label
2 Warnings d5a73e60: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 48845d50: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/user/application_security/policies/scan-result-policies.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @tyleramos
(UTC-5, 6 hours behind author)
@jprovaznik
(UTC+1, same timezone as author)
frontend @thutterer
(UTC+1, same timezone as author)
@jivanvl
(UTC-6, 7 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@7ee947eb
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits efa80453 and d5a73e60
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.16 MB 4.16 MB - -0.0 % mainChunk 3.12 MB 3.12 MB - 0.0 %
Note: We do not have exact data for efa80453. So we have used data from: c6d9f787.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- 48845d50 - Clean up FF scan_result_any_merge_request from frontend
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for d5a73e60expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 45 | 0 | 17 | 0 | 62 | ✅ | | Govern | 64 | 0 | 3 | 0 | 67 | ✅ | | Plan | 51 | 0 | 3 | 0 | 54 | ✅ | | Data Stores | 20 | 0 | 3 | 0 | 23 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Verify | 29 | 0 | 2 | 0 | 31 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Package | 15 | 0 | 1 | 0 | 16 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 238 | 0 | 30 | 0 | 268 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for d5a73e60expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 343 | 4 | 38 | 9 | 385 | ❌ | | Create | 138 | 0 | 30 | 2 | 168 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 501 | 4 | 70 | 11 | 575 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for d5a73e60expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 3 | 1 | 11 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 5 | 1 | 25 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@ffd99267
- Resolved by Alexander Turinske
- Resolved by Alexander Turinske
@mc_rocha could you please do the initial backend review? I think it will be interesting for you, as you're working on something potentially overlapping: [Feature flag] Cleanup `scan_result_policies_bl... (#432123 - closed)
requested review from @mc_rocha
- Resolved by Alexander Turinske
requested review from @arfedoro
- Resolved by Alexander Turinske
@mc_rocha
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label