Skip to content

Clean up FF scan_result_any_merge_request

Martin Čavoj requested to merge 432127-feature-flag-cleanup-scan_result_any_merge_request into master

What does this MR do and why?

This MR removes feature flag scan_result_any_merge_request which has been enabled by default in %16.7 in Enable scan_result_any_merge_request by default (!136298 - merged).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. In rails console, make sure to disable the feature flag in case it was enabled before 
    Feature.disable(:scan_result_any_merge_request)
  2. Visit Secure -> Policies and create a new Scan Result Policy
  3. Ensure that "Any merge request" rule type can be selected and there are no errors in the console
  4. Save a policy
  5. Edit the policy
  6. Ensure that "Any merge request" rule type is pre-selected and there are no errors
  7. Try also various combinations with the related feature flags:
    • scan_result_policies_block_force_push
    • scan_result_policies_block_unprotecting_branches

Related to #432127 (closed)

Edited by Martin Čavoj

Merge request reports