Skip to content
Snippets Groups Projects

Enable scan_result_any_merge_request by default

All threads resolved!

What does this MR do and why?

This MR enables scan_result_any_merge_request feature flag by default. The feature was rolled out globally 1 week ago.

It also enabled scan_result_policies_block_force_push which has been rolled out globally.

It also updates documentation and removes mentions of previously removed security_policies_branch_exceptions feature flag.

Please note that the MR is in draft because based on this discussion, the feature should be released together with [Feature flag] Rollout of `scan_result_policies... (#427260 - closed), which is in verification as of now. I updated this MR to include also scan_result_policies_block_force_push, which has been verified and rolled out globally as well.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #423988 (closed) and #427260 (closed)

Edited by Martin Čavoj

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @sashi_kumar and @rdickenson

  • Martin Čavoj changed the description

    changed the description

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 77689498

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 40     | 0      | 7       | 0     | 47    | ✅     |
    | Verify           | 32     | 0      | 0       | 0     | 32    | ✅     |
    | Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
    | Govern           | 48     | 0      | 0       | 0     | 48    | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 201    | 0      | 10      | 0     | 211   | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 77689498

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Govern | 177    | 1      | 10      | 6     | 188   | ❌     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 177    | 1      | 10      | 6     | 188   | ❌     |
    +--------+--------+--------+---------+-------+-------+--------+
  • Sashi Kumar Kumaresan approved this merge request

    approved this merge request

  • :wave: @sashi_kumar, thanks for approving this merge request.

    This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Sashi Kumar Kumaresan removed review request for @sashi_kumar

    removed review request for @sashi_kumar

  • Russell Dickenson approved this merge request

    approved this merge request

  • Russell Dickenson removed review request for @rdickenson

    removed review request for @rdickenson

  • Martin Čavoj added 453 commits

    added 453 commits

    Compare with previous version

  • Ghost User
  • Contributor
    1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Russell Dickenson approved this merge request

    approved this merge request

  • mentioned in epic &9706 (closed)

  • Martin Čavoj added 196 commits

    added 196 commits

    • c8c3ccdb...617a74af - 194 commits from branch master
    • e2f8e23f - Enable scan_result_any_merge_request by default
    • 507b465b - Enable scan_result_policies_block_force_push by default

    Compare with previous version

  • Martin Čavoj marked this merge request as ready

    marked this merge request as ready

  • Martin Čavoj changed the description

    changed the description

  • Ghost User
  • Martin Čavoj added 77 commits

    added 77 commits

    • 507b465b...f6583112 - 75 commits from branch master
    • 3d56a21f - Enable scan_result_any_merge_request by default
    • 0840499d - Enable scan_result_policies_block_force_push by default

    Compare with previous version

  • Martin Čavoj requested review from @sashi_kumar

    requested review from @sashi_kumar

  • Martin Čavoj changed the description

    changed the description

  • Martin Čavoj added 12 commits

    added 12 commits

    • 0840499d...dfe1b984 - 10 commits from branch master
    • e425087f - Enable scan_result_any_merge_request by default
    • 77689498 - Enable scan_result_policies_block_force_push by default

    Compare with previous version

  • Alexander Turinske resolved all threads

    resolved all threads

  • requested review from @aturinske

  • Alexander Turinske approved this merge request

    approved this merge request

  • Alexander Turinske enabled an automatic merge when the pipeline for addf5a1d succeeds

    enabled an automatic merge when the pipeline for addf5a1d succeeds

  • mentioned in commit a65e47cc

  • added workflowstaging label and removed workflowcanary label

  • Martin Čavoj mentioned in merge request !141506 (merged)

    mentioned in merge request !141506 (merged)

  • Please register or sign in to reply
    Loading