Enable scan_result_any_merge_request by default
What does this MR do and why?
This MR enables scan_result_any_merge_request
feature flag by default. The feature was rolled out globally 1 week ago.
It also enabled scan_result_policies_block_force_push
which has been rolled out globally.
It also updates documentation and removes mentions of previously removed security_policies_branch_exceptions
feature flag.
Please note that the MR is in draft because based on this discussion, the feature should be released together with [Feature flag] Rollout of `scan_result_policies... (#427260 - closed), which is in verification as of now. I updated this MR to include also scan_result_policies_block_force_push
, which has been verified and rolled out globally as well.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #423988 (closed) and #427260 (closed)
Merge request reports
Activity
changed milestone to %16.6
assigned to @mcavoj
- Resolved by Alexander Turinske
- Resolved by Martin Čavoj
@sashi_kumar could you please do the initial review? Even though we should release the feature together with [Feature flag] Rollout of `scan_result_policies... (#427260 - closed), I wanted to prepare the MR in advance.
@rdickenson could you please review the documentation changes in this MR?
requested review from @sashi_kumar and @rdickenson
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@3c2092e4
added documentation label
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 77689498expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 40 | 0 | 7 | 0 | 47 | ✅ | | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Govern | 48 | 0 | 0 | 0 | 48 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 201 | 0 | 10 | 0 | 211 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 77689498expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Govern | 177 | 1 | 10 | 6 | 188 | ❌ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 177 | 1 | 10 | 6 | 188 | ❌ | +--------+--------+--------+---------+-------+-------+--------+
@sashi_kumar
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @sashi_kumar
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@223a25bb
added Technical Writing docsfeature labels
removed review request for @rdickenson
added twfinished label
added 453 commits
-
915fe85c...f888354e - 452 commits from branch
master
- c8c3ccdb - Enable scan_result_any_merge_request by default
-
915fe85c...f888354e - 452 commits from branch
- Resolved by Alexander Turinske
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/user/application_security/policies/scan-result-policies.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@d125a78b
mentioned in epic &9706 (closed)
added 196 commits
-
c8c3ccdb...617a74af - 194 commits from branch
master
- e2f8e23f - Enable scan_result_any_merge_request by default
- 507b465b - Enable scan_result_policies_block_force_push by default
-
c8c3ccdb...617a74af - 194 commits from branch
- Resolved by Alexander Turinske
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@3056ea20
added 77 commits
-
507b465b...f6583112 - 75 commits from branch
master
- 3d56a21f - Enable scan_result_any_merge_request by default
- 0840499d - Enable scan_result_policies_block_force_push by default
-
507b465b...f6583112 - 75 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@bf122ab0
requested review from @sashi_kumar
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@0b7bd0a8
added 12 commits
-
0840499d...dfe1b984 - 10 commits from branch
master
- e425087f - Enable scan_result_any_merge_request by default
- 77689498 - Enable scan_result_policies_block_force_push by default
-
0840499d...dfe1b984 - 10 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@addf5a1d
requested review from @aturinske
enabled an automatic merge when the pipeline for addf5a1d succeeds
mentioned in commit a65e47cc
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2678 (merged)
mentioned in merge request !141506 (merged)