Shared subgroups for group protected environment
What does this MR do and why?
This MR implements #437641 (closed) and adds a include_shared_groups
parameter to the /-/autocomplete/group_subgroups.json
endpoint
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Create group
main
- Assign the group to
Ultimate
plan (view the group in admin area, and select an Ultimate plan inPermissions and group features
section. - Create sub-group
users
- Create a group
invited-group
- Invite this group to the
main
group (go to themain
group page, navigate toManage -> Members
- Navigate to group level CI/CD settings for `main group
- Create new protected environment
- Check that both groups are selectable in the protected environment (
users
andinvited group
)
Merge request reports
Activity
- A deleted user
added backend database databasereview pending frontend labels
3 Warnings 9720d89b: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 544c993e: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
2 Messages CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
app/finders/groups_finder.rb
ee/app/finders/autocomplete/group_subgroups_finder.rb
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @tigerwnz
(UTC+8, 7 hours ahead of author)
@schin1
(UTC+8, 7 hours ahead of author)
database @johnmason
(UTC-5, 6 hours behind author)
@jon_jenkins
(UTC-6, 7 hours behind author)
frontend @syarynovskyi
(UTC+2, 1 hour ahead of author)
@deepika.guliani
(UTC+5.5, 4.5 hours ahead of author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Userchanged milestone to %16.9
added featureenhancement groupenvironments typefeature workflowin review labels
added devopsdeploy sectioncd labels
assigned to @andrei.zubov
removed database label
This MR depends on !141067 (merged)
removed databasereview pending label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1ab0ab52 and a08c70b1
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.16 MB 4.16 MB - 0.0 % mainChunk 3.12 MB 3.12 MB - 0.0 %
Note: We do not have exact data for 1ab0ab52. So we have used data from: 3f4f3d86.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost UserE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for a08c70b1expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 51 | 0 | 3 | 0 | 54 | ✅ | | Govern | 64 | 0 | 3 | 0 | 67 | ✅ | | Package | 15 | 0 | 1 | 0 | 16 | ✅ | | Create | 45 | 0 | 17 | 0 | 62 | ✅ | | Verify | 29 | 0 | 2 | 0 | 31 | ✅ | | Data Stores | 20 | 0 | 3 | 0 | 23 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 238 | 0 | 30 | 0 | 268 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for a08c70b1expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 3 | 1 | 11 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 5 | 1 | 25 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost User- Resolved by Sylvester Chin
Hi @partiaga! Could you please have a look at this MR from the backend ? It's still blocked by !141067 (merged), but hopefully it'll be merged soon.
requested review from @partiaga
- Resolved by Anna Vovchenko
Hi @anna_vovchenko ! Could you please have a look at this MR from the frontend ? As I mentioned above, it's still blocked by !141067 (merged), but hopefully it'll be merged soon.
requested review from @anna_vovchenko
- Resolved by Anna Vovchenko
@anna_vovchenko
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
- A deleted user
added database databasereview pending labels