Added arugment error when pipeline is nil
What does this MR do and why?
FindingBuilder class inside the VulnerabilityScanning module was not checking for the edge case when pipeline argument is nil for the Sbom::Occurence which was causing GlobalAdvisoryScanWorker to fail. Thus, an argument error is raised to let the AdvisoryScan job continue it's flow.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #437120 (closed)
Merge request reports
Activity
added typebug label
Hey @chirayu999!
Welcome to our community! We're excited to have you here, and can't wait to review this first MR with you!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.This message was generated automatically. You're welcome to improve it.
added 1st contribution Community contribution workflowin dev labels
assigned to @chirayu999
1 Warning 3079b05c: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @lma-git
(UTC-8)
@dbalexandre
(UTC+0)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded linked-issue label
- Resolved by Kerri Miller
@gitlab-bot ready @fcatteau . Hi, can you please review this MR. Thanks!
added workflowready for review label and removed workflowin dev label
requested review from @fcatteau
@fcatteau
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
mentioned in issue gitlab-org/quality/triage-reports#15695 (closed)
added backend devopssecure labels
added sectionsec label
added groupcomposition analysis label
added bugfunctional severity2 labels
changed milestone to %16.8