Skip to content

Fix alignment issue with scan summary

Lorenz van Herwaarden requested to merge scanner-alignment-off into master

What does this MR do and why?

Related #418296 (closed)

This improves the layout of the Scan details items. When some scanners don't have downloadable reports, like when reports are expired, the alignment is off due to using css flexbox. This MR changes the approach to use CSS grid which allows for a more robust layout.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-01-08_at_11.56.59 Screenshot_2024-01-08_at_11.58.02
Screenshot_2024-01-08_at_11.57.24 Screenshot_2024-01-09_at_12.08.39

How to set up and validate locally

Prerequisites

  1. You need an EE license
  2. You need to have runners enabled (See $2408961 for setting up a runner)
  3. Import https://gitlab.com/gitlab-examples/security/security-reports
  4. Run a pipeline on master

Validate

  1. manually force the expiration of security report artifacts of the security-reports project with instructions here
Edited by Lorenz van Herwaarden

Merge request reports