Skip to content

Refactor ApplicationSetting specs to use validate_numericality_of

Abdul Wadood requested to merge 420321-refactor-validates-numericality-spec into master

What does this MR do and why?

Instead of using allow_value or not_to allow_value using validate_numericality_of results in concise specs.

The validate_numericality_of matcher checks if the argument is a string or a number so we don't need to test it explicitly in the tests. The common examples are now under the same context using table syntax.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #420321 (closed)

Merge request reports