Add configuration option for member deletion rate limit
Proposal
We made a change that introduced a rate limit for member deletion events using the API, in order to mitigate a Sidekiq performance issue. This has negatively affected at least one self-managed customer's (GitLab internal) workflow, as they're now getting failures for automated member deletions using the API. Since they're self-managed, I believe that we should be able to introduce a configuration option to either disable or adjust this rate limit.
If we cannot add configuration options for this rate limit, I propose that we add more information to the relevant documentation with an explanation, and link back to this issue.
Workarounds
The only workaround I can see here is to add a wait
to any operation that's exceeding this rate limit. However, given the way the customer is using this, introducing a wait
is cumbersome and noticeably slows down processes that were previously very quick.
Implementation guide
This should be straightforward to add a new columm, then use the new column to be configurable.
We then expose the new column to be editable in the admin UI. Grep for issues_create_limit
to see how it is done in the past.
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Keelan Lang assigned to @klang
assigned to @klang
- 🤖 GitLab Bot 🤖 added devopsdata stores sectioncore platform labels
added devopsdata stores sectioncore platform labels
- Keelan Lang changed the description
Compare with previous version changed the description
- Maintainer
BTW, the rate limit is currently 60 calls per group per user per minute.
- Thong Kuah changed milestone to %16.4
changed milestone to %16.4
- Thong Kuah changed milestone to %16.5
changed milestone to %16.5
- Thong Kuah added workflowplanning breakdown label
added workflowplanning breakdown label
- Maintainer
Reason for the rate limit
I propose that we add more information to the relevant documentation with an explanation, and link back to this issue.
The rate limit was put in place because many calls to this end-point can saturate the Sidekiq queue enough that features like merge requests stop showing recent commits and CI pipelines were not processing.
Edited by Thong Kuah - DeveloperResolved by Christina Lohr
@klang Are you planning to work on this issue or can I unassign you?
1 reply Last reply by Keelan Lang
- Christina Lohr added workflowrefinement label and removed workflowplanning breakdown label
added workflowrefinement label and removed workflowplanning breakdown label
- Christina Lohr added backend label
added backend label
- Keelan Lang unassigned @klang
unassigned @klang
- Thong Kuah marked this issue as related to #423404
marked this issue as related to #423404
- Thong Kuah changed the description
Compare with previous version changed the description
- Thong Kuah set weight to 2
set weight to 2
- Arturo Herrero added workflowready for development label and removed workflowrefinement label
added workflowready for development label and removed workflowrefinement label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13979 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13979 (closed)
- Christina Lohr added milestonep2 label
added milestonep2 label
- Christina Lohr added Category:Groups & Projects label
added Category:Groups & Projects label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14077 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14077 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14146 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14146 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14240 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14240 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14354 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14354 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14446 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14446 (closed)
- Christina Lohr added to epic &8487
added to epic &8487
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14517 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14517 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %16.6
changed milestone to %16.6
- 🤖 GitLab Bot 🤖 added missed:16.5 label
added missed:16.5 label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14612 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14612 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14678 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14678 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14796 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14796 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14892 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14892 (closed)
- 🤖 GitLab Bot 🤖 changed milestone to %16.7
changed milestone to %16.7
- 🤖 GitLab Bot 🤖 added missed:16.6 label
added missed:16.6 label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#14962 (closed)
mentioned in issue gitlab-org/quality/triage-reports#14962 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15058 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15058 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15172 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15172 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15267 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15267 (closed)
- Christina Lohr added milestonep1 label and removed milestonep2 label
added milestonep1 label and removed milestonep2 label
- 🤖 GitLab Bot 🤖 added 1 deleted label
added 1 deleted label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15387 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15387 (closed)
- Christina Lohr changed milestone to %16.8
changed milestone to %16.8
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#15483 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15483 (closed)
- Abdul Wadood assigned to @abdwdd
assigned to @abdwdd
- Abdul Wadood added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Abdul Wadood mentioned in merge request !140633 (merged)
mentioned in merge request !140633 (merged)
- Maintainer
Moved !140633 (merged) to review.
2 Collapse replies - Maintainer
The above MR got merged and I have verified it locally and it's working as expected. Closing this issue.
/cc @klang
1
- Abdul Wadood added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Abdul Wadood mentioned in merge request !140648 (merged)
mentioned in merge request !140648 (merged)
- Abdul Wadood mentioned in merge request !140653 (merged)
mentioned in merge request !140653 (merged)
- Abdul Wadood mentioned in merge request !140657 (merged)
mentioned in merge request !140657 (merged)
- Abdul Wadood mentioned in merge request !140658 (merged)
mentioned in merge request !140658 (merged)
- Abdul Wadood mentioned in merge request !141765 (merged)
mentioned in merge request !141765 (merged)
- Christina Lohr changed milestone to %16.9
changed milestone to %16.9
- Abdul Wadood added workflowcomplete label and removed workflowin review label
added workflowcomplete label and removed workflowin review label
- Abdul Wadood closed
closed
- Christina Lohr changed milestone to %16.8
changed milestone to %16.8
- Christina Lohr removed 1 deleted label
removed 1 deleted label
- Christina Lohr changed epic to &14016
changed epic to &14016
- 🤖 GitLab Bot 🤖 added devopstenant scale grouporganizations sectioninfrastructure platforms labels and removed devopsdata stores grouptenant scale [DEPRECATED] sectioncore platform labels
added devopstenant scale grouporganizations sectioninfrastructure platforms labels and removed devopsdata stores grouptenant scale [DEPRECATED] sectioncore platform labels