Replace ruby-sass with dart-sass (node)
What does this MR do and why?
This MR removes the deprecated Ruby Sass and replaces it with Dart Sass using the Javascript library.
It introduces cssbundling-rails
to hook into Sprockets Asset Pipeline. Feedback is welcome, and decisions around architecture and references that would require updating would also be useful
Yes thing is potentially a big change, but with it I hope we can move away from Sprockets3, maybe even skip Sprockets4, and move straight to Propshaft and jsbundling-rails.
Status
See - #438278 (closed)
This MR adds cssbundling-rails
alongside sassc-rails
. By default sassc-rails
continues to be used, but cssbundling-rails
can be used by enabling USE_NEW_CSS_PIPELINE
env var.
Proposals
- Introduce a
{ee?,jh?}app/assets/stylesheets/entrypoints
directory, being the single point where all entrypoint CSS files are defined. Then all the files would have to be moved around, but I presume very little will have to be updated- the command would just be
sass app/assets/stylesheets/entrypoints/:app/assets/builds
while everything insideentrypoints/
has the same structure as it does now
- the command would just be
- Possibly introduce PostCSS as a suitable Node based CSS Processor. Adds some tendency of processing Sass files
Hurdles
-
sass
Javascript API is very poor. Meaning the script forbuild:css
can be used to "compile" production assets. But for things like--watch
or the Command Line interface, it's not replicable via the JS API. So we may need to:
- Write super funky JS to construct a command line command to run, both for production and development
- Keep
build:css
for production asset building, and use the JS API to conditionally import EE/JH assets. And use maybe awatch:css
script which invokessass
via CLI
- Think about future of
@import
, as Sass is planning on removing it
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Application still looks and should look exactly the same
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
Picture from the Review App
How to set up and validate locally
Clear your local assets: rm -rf public/assets tmp/cache/assets/
. After that a gdk restart rails-web
should be sufficient.
Old way of compiling css
This MR should not mess with the status quo, so starting your gdk
normally, on this branch should have working styles
If you e.g. add body { color: green !important; }
to app/assets/stylesheets/application.scss
, some text color should change to green after a page reload
New way of compiling css
Do the following in one terminal window:
gdk stop
rm -rf public/assets tmp/cache/assets/
export USE_NEW_CSS_PIPELINE=1
gdk start
At the same time, in another terminal window, do:
yarn run build:css --watch
If you now do change e.g. application.scss
, the second terminal window should read: application.scss changed, recompiling
and after a page reload the change you did should be effective.
Comparing assets
This MR also includes a script which runs production compilation of the assets in both modes and places two diffable folders in tmp/css_compare
. Simply run: ./scripts/frontend/compare_css_compilers.sh
. This shows that the production mode is working for both, but we need to figure out the actual diff between the two before we can make the switch.
Merge request reports
Activity
Hey @ar-mali!
👋 Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @ar-mali
4 Warnings ⚠ 7f989fb2: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. ⚠ 9a0ce534: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ⚠ 8c781077: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. ⚠ featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message 📖 This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the
danger-review
job.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @mallocke
(UTC+13)
@stanhu
(UTC-8)
database @subashis
(UTC-7)
@Andysoiron
(UTC+1)
frontend @lcallahan
(UTC-7)
@jerasmus
(UTC+1)
~"Tooling" Reviewer review is optional for ~"Tooling" @psjakubowska
(UTC+1)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Rubygems
This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Dangermentioned in issue #370814 (closed)
After a bit of playing around and trying to reuse the
resolveGlobUrl
function, I don't think we can write a custom Importer to resolve globs https://sass-lang.com/documentation/js-api/interfaces/importer/#canonicalizecanonicalize
has to return aURL
which has to be a single, instead of multiple URLsmentioned in issue gitlab-org/quality/triage-reports#15473 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15487 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15488 (closed)
- Resolved by Muhammed Ali
@ar-mali Is there an issue tracking this work we can point reviewers to?
added featureenhancement frontend groupfoundations labels
requested review from @leetickett-gitlab
added typefeature label
added devopsmanage sectioncore platform labels
- Resolved by Lukas Eipert
added pipeline:run-review-app label
- A deleted user
added backend database databasereview pending labels
removed pipeline:run-review-app label
added pipeline:run-review-app label
removed pipeline:run-review-app label
added 2 commits
- Resolved by Muhammed Ali
added pipeline:run-review-app label
removed pipeline:run-review-app label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-review-qa:
❌ test report for 86fcc96dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 0 | 8 | 2 | 2 | 10 | ❌ | | Data Stores | 0 | 2 | 0 | 0 | 2 | ❌ | | Govern | 0 | 3 | 0 | 0 | 3 | ❌ | | Plan | 0 | 3 | 1 | 0 | 4 | ❌ | | Monitor | 0 | 4 | 0 | 0 | 4 | ❌ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 20 | 4 | 2 | 24 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
✅ test report for 86fcc96dexpand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Plan | 249 | 0 | 10 | 3 | 259 | ✅ | | Create | 550 | 0 | 67 | 8 | 617 | ✅ | | Govern | 292 | 0 | 20 | 10 | 312 | ✅ | | Package | 226 | 0 | 17 | 0 | 243 | ✅ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 119 | 0 | 1 | 0 | 120 | ✅ | | Verify | 138 | 0 | 27 | 6 | 165 | ✅ | | Release | 15 | 0 | 3 | 0 | 18 | ✅ | | Manage | 40 | 0 | 10 | 4 | 50 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Monitor | 36 | 0 | 13 | 0 | 49 | ✅ | | Fulfillment | 8 | 0 | 69 | 0 | 77 | ✅ | | Analytics | 7 | 0 | 0 | 0 | 7 | ✅ | | ModelOps | 0 | 0 | 8 | 0 | 8 | ➖ | | Configure | 1 | 0 | 9 | 0 | 10 | ✅ | | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | | Secure | 6 | 0 | 3 | 0 | 9 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 1697 | 0 | 264 | 31 | 1961 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 41b08ed2 - Chore: use url() css processor to reference assets
- Resolved by Muhammed Ali
- Resolved by Muhammed Ali
added pipeline:run-review-app label
removed pipeline:run-review-app label
@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
@leetickett-gitlab
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
changed milestone to %16.8
requested review from @leipert
added 262 commits
-
86fcc96d...d77b98f8 - 262 commits from branch
gitlab-org:master
-
86fcc96d...d77b98f8 - 262 commits from branch
added 6 commits
Toggle commit listremoved review request for @leetickett-gitlab
mentioned in issue #436035 (closed)
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Muhammed Ali
- Resolved by Muhammed Ali
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Muhammed Ali
added JiHu impacted label
@gitlab-bot unassign_review @leipert
Setting this MR to draft. If you want to continue a review, then look at Version 18 of the diff
Edited by Muhammed Aliadded 368 commits
-
25c408fa...b95e38eb - 363 commits from branch
gitlab-org:master
- 59ec8504 - Setup cssbundling-rails
- 6db72d95 - Remove Asset Helpers in SCSS files
- 826e97a5 - Add custom Sass compile script to be more configurable
- 7c6115f8 - Remove unneeded paths from Rails configuratin
- 02da5401 - Chore: spelling corrections related to Sass/SaaS
Toggle commit list-
25c408fa...b95e38eb - 363 commits from branch
mentioned in merge request !141055 (merged)
mentioned in merge request gitlab-community/gitlab!14 (merged)
added 174 commits
-
b12362d2...db0415f5 - 170 commits from branch
gitlab-org:master
- b2ae9607 - Setup cssbundling-rails
- 1235c33a - Add custom Sass compile script to be more configurable
- 1f2dd4e5 - Chore: spelling corrections related to Sass/SaaS
- 8764322b - [skip ci] Add sassc-rails and ignore cssbundling-rails in CI and deploy
Toggle commit list-
b12362d2...db0415f5 - 170 commits from branch
added 1 commit
- 97223eaf - Add sassc-rails and ignore cssbundling-rails in CI and deploy
I've noticed after second glancing at the codebase that Sprockets does not compile any of the JavaScript and it's all done by Webpack in production right, and either Webpack or Vite in Development.
I think this would definitely make it easier to migrate away from Sprockets and to Propshaft. Also noticed Propshaft is still in "beta", so I don't know how to feel about that
- Resolved by Lukas Eipert
added 6 commits
- bf8290b2 - Make eslint and prettier happy
- f2bcec80 - Move from custom file iteration to glob based solution
- 6cc994ba - Split resolution and compile function
- 0880b099 - Add support for JiHu page_bundle styles
- 8929aad6 - Implement a --watch mode
- d82d075c - Merge branch 'replace-sass-improve-script' into 'replace-sass'
Toggle commit list- Resolved by Lukas Eipert
- Resolved by Peter Leitzen
- Resolved by Lukas Eipert
@ar-mali WDYT, should I extract the actual
javascript
compiler file into a separate MR? The current status quo is mainly written by myself, so I'd be happy to see it through review.
- Resolved by Lukas Eipert
@leipert I've tested the production compilation of the assets (yet to test development experience of the
--watch
flag)- I compiled assets with
bin/rails gitlab:assets:compile
and committed them - Then I compiled with
USE_NEW_CSS_PIPELINE=1 bin/rails gitlab:assets:compile
and committed them - I ran `git diff HEAD~1..HEAD -- *.css
- Below are some snippets that show the line diffs, I will also include a summary of the changes as it's too long to upload
application.css
diff --git a/public/assets/application-ca3fa3ed504c04d35d20b7c885eee9e404319f76439dc6a5ee812000bc0fa5e8.css b/public/assets/application-7d318affdc2c6f0ca6e3fa57863df0e3e03b82 cd808f63c23eaf7e3f92f90a91.css similarity index 58% rename from public/assets/application-ca3fa3ed504c04d35d20b7c885eee9e404319f76439dc6a5ee812000bc0fa5e8.css rename to public/assets/application-7d318affdc2c6f0ca6e3fa57863df0e3e03b82cd808f63c23eaf7e3f92f90a91.css index 56075c2419f8..20f976c236e7 100644 --- a/public/assets/application-ca3fa3ed504c04d35d20b7c885eee9e404319f76439dc6a5ee812000bc0fa5e8.css +++ b/public/assets/application-7d318affdc2c6f0ca6e3fa57863df0e3e03b82cd808f63c23eaf7e3f92f90a91.css @@ -1,5 +1,4 @@ -@charset "UTF-8"; -/* line 1, node_modules/@gitlab/at.js/dist/css/jquery.atwho.css */ + .atwho-view { position: absolute; top: 0; @@ -15,7 +14,6 @@ z-index: 11110 !important; } -/* line 16, node_modules/@gitlab/at.js/dist/css/jquery.atwho.css */ .atwho-view .atwho-header { padding: 5px; margin: 5px; @@ -26,7 +24,6 @@ font-weight: bold; } -/* line 26, node_modules/@gitlab/at.js/dist/css/jquery.atwho.css */ .atwho-view .atwho-header .small { color: #6f8092; float: right; @@ -36,34 +33,28 @@ font-weight: normal; } -/* line 35, node_modules/@gitlab/at.js/dist/css/jquery.atwho.css */ .atwho-view .atwho-header:hover { cursor: default; } -/* line 39, node_modules/@gitlab/at.js/dist/css/jquery.atwho.css */ .atwho-view .cur { background: #3366FF; color: white; }
and another snippet
@@ -530,34 +496,28 @@ ul ol { margin-bottom: 0; } -/* line 143, node_modules/bootstrap/scss/_reboot.scss */ dt { font-weight: 600; } -/* line 147, node_modules/bootstrap/scss/_reboot.scss */ dd { - margin-bottom: .5rem; + margin-bottom: 0.5rem; margin-left: 0; } -/* line 152, node_modules/bootstrap/scss/_reboot.scss */ blockquote { margin: 0 0 1rem; }
I've inspected a few of the other CSS files and notes that most of them are moved comments
git diff --stat=260 -- \*.css
...cation-ca3fa3ed504c04d35d20b7c885eee9e404319f76439dc6a5ee812000bc0fa5e8.css =\> application-7d318affdc2c6f0ca6e3fa57863df0e3e03b82cd808f63c23eaf7e3f92f90a91.css} | 14253 +++++++++++-------------------------------------------------------------------- ...k-ecdd90e1bfc0194e6379b9c936bec0183ad93c815c65c56236fe817b8e15352c.css =\> application_dark-9a60aef57a74563893fc67629e5af2d1828d01c04208a09ac8831d711590c403.css} | 15409 ++++++++++++-------------------------------------------------------------------------- ...6317bbf1d2da74b6d671e9e7e31657f798fdb3be6877e65d8fdde404179d9.css =\> application_utilities-c1c09daadc25df891283674909d4b474aba0c7ac5e48e15fba19a9d40d4b5f33.css} | 2455 +------------- ...2ce12be3da6ab61ea135a85b11705459c6a947cbb38a96b8eb21684b.css =\> application_utilities_dark-e700fc8422004eb49cd62031b596bf192c243f994b1e8b2e6f2e788a5614175a.css} | 2455 +------------- ...a5f3fca724d4c491da488ea3b5a333f48d666f953cf753e134a985ba32a50f66.css =\> disable_animations-10eb8192b3f16a597c60b1669313f2c2df7817aa9cd8fbacc3b797ac69133a6e.css} | 5 +- ...ites-4f67ae6aa6819d71dbb59690230e661665a4f73c5d1cb70bb54f6d0127019a67.css =\> emoji_sprites-2c5df9e1a894e966dcc4143925b45a382c53fc2fc1be1e7d8f5ef3da05bc8e36.css} | 1797 ---------- .../{errors-ca6b2b1b3c47ae8cd05efd67a524e85951717fc43a9550658292055f83aac29b.css =\> errors-20e68bfe88cbf37f97bc843d5f695179009efb7387030c4221fbb2ec145b97ce.css} | 801 +---- .../{fonts-b7e1a1e250252a4c5c14182d073e74aec0231feafa20b9603801c840ecc2fa7c.css =\> fonts-c594094538feb1d1eb09a3cf11dd2e40a4d037c3f866bf51b651483a8f1e0689.css} | 18 +- ...cd41e8ca74e38c79afb6d0758183a30741670e3690c5acd0a8d9545.css =\> diff_custom_colors_addition-896fe1942d1219abe736a7214eec4be5b6c2664dba5d9c72e82ea1bb8b0d5c02.css} | 10 +- ...5f4969befae040f0a46ec6191e97d0b5205025aa9cd9c834800ac90.css =\> diff_custom_colors_deletion-c184456e5dc4dbed67c26d3ae71d6fd6d9186116ae8970676c3cf95d0f143d25.css} | 10 +- .../themes/{dark-d0c78fec6f85e33e681cadefff7d9e4126cb14c4c04f867b5abb88380f1644cc.css =\> dark-12a8d2823ff213fb249618936a5622d9dbe4df2a5510e30318c7f4b70b409443.css} | 309 +- .../{monokai-0409e3510bb4d2a1863ea84b9804e264d9752dc4e94c45d59f7386a5f3745ffc.css =\> monokai-00f3f65acc29c21b9969407ae7e4186a5a46b7e5dd164e61414285cd2e190264.css} | 303 +- .../themes/{none-8924fd3952764d2971bd0204deb165fefee9a3da98b7439ad5b488c4b26e4c39.css =\> none-aa1fb30dbbc9ee4aaf801881c79219fd45955a22fee8bba4dc9c2b543374f148.css} | 239 +- ...ark-f7db4ed58ce0d598664fb31ed8e6c80c8daf30ca3d4b7e4e77331265b1ea6f59.css =\> solarized-dark-8ef8d87ff01d01d9fb85e31a3f6d3d69dfd72db8aaf901fb9244477b9432a968.css} | 313 +- ...ht-32ef3dad142a16311c80d87e976f447bf740a9191de7a15fd9772fd6541e16dc.css =\> solarized-light-4bb5090716612374ca9a7b6087e71b6cbe32d0206bd88528ca580dd20ad3cd36.css} | 277 +- public/assets/highlight/themes/white-21c4e58aee4d09d5840bf5781052f8002096309f0dbada4d825d209c4308f223.css | 1445 ++++++++ public/assets/highlight/themes/white-485de7871699859cfeed675a9532e21f126c9f3e29d1387f2426ced84bbe98e7.css | 1698 ---------- ...ridstack-11de4c9f77a51c352047b9dc4ff1f498cf95b7a8bd43c6a592ff815b7117507d.css =\> gridstack-1d653e3a21bf97e8de194f9f9495c8d3b45ffc86013df1819ef062ea0645bee2.css} | 56 +- .../{mailer-bc409eea430e5d6174f587451f89b3c96eccdd00869526cb8d8741aa5e9b4bd7.css =\> mailer-0d82ad5183d0e94b71ec81856d5728c6e302ed44691b13a3ee72145e856f2fa8.css} | 45 +- ...d56acf5a733f2feaf3993f3ee7b08902ceff67e920adc067cdaaadc647a1.css =\> mailer_client_specific-c91b8a9535db98cc0776aa14049dca3005b9aac867b6932b462094c9e4cbab09.css} | 14 +- ...a6daf97559c267890e45e2902434d5436cd02fd2a98c34f47209f5e1ca01.css =\> highlighted_diff_email-c7445d2c519aeb01faf187d6c0b8f97264485d2f891689001001a09b456f1374.css} | 91 +- .../{notify-d8a12ac38da338cacc67a2f8734e7cfb89e73717df1ea0b8d59ad2c101e88d5d.css =\> notify-82e3ab6f30f1b26cdedf34603ab278bc0941b066143d6dc22cad4bfe0ab91a61.css} | 23 +- ...ed-74e6f88f03519643ec6a113d0da2c2fbf045c726da22c78ec8371e0a05bec314.css =\> notify_enhanced-22444790616cbd671a0a865cc12e9661bbe98946979dfdc3c68e347810035698.css} | 557 +--- ...1c1bf2967429c763bf01c63b05bbcab550e292cf58abc33.css =\> \_mixins_and_variables_and_functions-a407d72aff45c365b42f8b09a81f1d67deb8278963b5ea75bfde27988aeba1a9.css} | 6 +- public/assets/page_bundles/admin/application_settings_metrics_and_profiling-38dcf9b199c105f11b5e5f30cb273cce58725cc0bd14c66fdff86efa67c97d82.css | 3 + public/assets/page_bundles/admin/application_settings_metrics_and_profiling-6428a453467e474c1399fefc984ede8241890b99a86a43f5ef63abdc127b8297.css | 4 - .../admin/elasticsearch_form-779d3777569b2474bb074e656424c05f636dfa71b4f11c53b4f1aa8ca0b47b46.css} | 12 +- ...ble-dd947c9d5f0bdfad93d4af15e5aa32b1bae5667145959e0ec23510dbdb2cbb03.css =\> geo_replicable-186922d55aabc1f50f6cd1e05e412f5bcef5c271acd8594673a529a56cf77631.css} | 12 +- ...eo_sites-e8b26169f277815e186db17736131789708ae0f13caeea50836059c42715d279.css =\> geo_sites-346e3cb89c3c8e374fe56b6227396ec6989830074ae93f85957e24bdf7ae6fa3.css} | 20 +- ...556f683f09a222f94bd0ef4087fc38e02c87bc3868672275bd91cddb87.css =\> alert_management_details-83615c4eccbec88489ffd4c1913fc1e97a10ad62c1ff024bd810f5aea818b551.css} | 21 +- ...d1061c2a568f5fef10fd471aecf9460c399b1134a4dd9875f2c761ed8.css =\> alert_management_settings-21fd6c9fce9570ae8a19eaaff35d93510ec6679bed2467946a4b586fbd9d954c.css} | 9 +- ...{billings-565a248c69d03f7e618d9dfce05399316653d7f88ff4c9199cd975b98a118149.css =\> billings-77b986fb8df1c33a4dd61f630c299fabbcc5c3ea8c41c38e8296218f84915c65.css} | 88 +- .../{boards-1b87acf87c7d91fdf54f113a2f51266226d6c5cd58ea87fa7508b919e5bf62c6.css =\> boards-f23ac005820a5a51b4070ad008e9ff306db2f7551115b51f66e6023e49bf633b.css} | 121 +- ...{branches-0b5dda10c3a4bfb331055a9d6e13f35e3f7b3e017891669a33459c2c553b4965.css =\> branches-110a26ff7883d87a24dc4a71e4a0a67134d3244cc7bba7db98f1f173090f1df6.css} | 23 +- .../{build-a7150ccc0f9eef14df0c17b16d7c2ec16e70654760d86150a0bc92b5551373a5.css =\> build-71a72b18f1b1a63abaae8e19b7f06291eb5c03356e5518634179fb5b99d9dfe0.css} | 99 +- ...ngs-44fddc9f5f9e272d40001387ba78e22604bdc44368d135c4872a62f3a9faebf8.css =\> ci_cd_settings-dbc8c33967297d283074d73736e1886b541af3334737c99afda01c939cc94fea.css} | 2 - ...i_status-2a7c77c2b77dc748de9948f5a05c2b651b6a5d92c226c912944da89d7c4222d5.css =\> ci_status-3d71ea0c8ba63ce0edba5a8e653a2be6032362f6763db352d3e6586da2b6fd96.css} | 39 +- ...nts-7c4600811cc8d796e95555a45a984f7818b20cb650549e4f5de69a8cd64bb2e8.css =\> cluster_agents-560fed2930c1bd0ffe09b7e15e8b65d510575d0a18a8f93d6b996fca5aa4b7c3.css} | 9 +- ...{clusters-eb3b9f7615a66d03e16e0ffc8ae440f7e60b71fedd4cbb4d76e9276a345b5e9b.css =\> clusters-6439ca7cd4c1121186cddb1afb7b8ee808427a524b67c025534bbe6485585e4a.css} | 17 +- ...cs-45b781a812a207497d514706c08b7a6a922277fd66102ac7cfad32eec194969d.css =\> cycle_analytics-d62eb29396cc53c7aec82994ad70f4e6119ef50ca67ced8a08c7634962c218eb.css} | 19 +- ...ashboard-a9b16ad24469a6a8d8e2b07747cbf27cdda10074e15c4fa01c175ed82c45f41f.css =\> dashboard-4ef9166e5123cc203cdf5263ed8615222fee8df177ea1181f51664c08342493f.css} | 7 +- ...b7c0d2eba455e6ec106948497b804030719fb74619ca3b4c7e884b8a8ca0c6d9.css =\> dashboard_projects-b12e300273ff2a14c98e8110b8967ada80682c9f7db4e6227492a65049c76386.css} | 12 +- ...-59efc066485fdd639a9977f5a6d0b3c427d36699b68faa83c814003554b98ac2.css =\> design_management-b36df2329295cc4b898a63ac2253242647d31b0868d14cb1b9a9d42e7f2cf393.css} | 61 +- ...ts-2dba1172c5b562e61a40c223da9e3820423a4251d7b2be7e2779e8fcf5406f98.css =\> dev_ops_reports-c69a2ebdb18725cb326aec7394772739242b379da15ddf4f48e2adf8928f51f3.css} | 33 +- .../{editor-6a2b763e56747fa67f779e44a90552ca4b1d2a50612b90fab9865a1f1a14297f.css =\> editor-ded07cbd4cd5759a3740aae995710264996f346f81881cddfc370fde92355de5.css} | 66 +- ...ments-8a4ef0a79988d5915b433d9154fc26e271e21fc913126dc32792449a8e174415.css =\> environments-3ece3254d35d7c6819835e84c2733413ca84cdc67931b2b1c13adee1753d9ade.css} | 65 +- .../{epics-d2f7cf9c180a26dad336c858b12b7b3758ff4d77a65ebd2fbb270d6466b5f592.css =\> epics-0e1dc6ac0516f4c28f566730a2add6f3600f477bbf87e026aa883e216c916783.css} | 14 +- public/assets/page_bundles/error_tracking_details-280880d0dd82e754b742ef298cf351ef4dccaada1f546c30c35cdc6118823bb6.css | 768 +++++ ...0137f49e2a64b2e67f3562ff0968ee1fc6bb71f65cecb62f1f88b1270a68e0.css =\> error_tracking_index-cf0cca2437f38ce316da1b0924bbe8d36c914922fcc181ef0bebc30cf071a424.css} | 12 +- public/assets/page_bundles/escalation_policies-0648bc5abbd06ec72515252727d186919d8969045f39cac20cc8b6261f38ff98.css | 815 ----- public/assets/page_bundles/escalation_policies-55a75841c91ed093e455e5529c60b41ae1594f811a67c68b14d38e1d05a3ec12.css | 802 +++++ ...harts-aafb1bbe40928c763da3e6002b521ed1689a1cf8fd2990d84890b94869d08e32.css =\> graph_charts-11eb955bf77251c6c64a0dc67abca0c217e754f190a8f84800a704e57c61c3ec.css} | 15 +- .../{group-ea16bb0ebb9ffabe87b3595bc093b2946a424a8d548aeb80bb02c3f64545cf17.css =\> group-78eb0d524b5e20702134a1b50b89ed23c050959d0e3712262f246899620cfabe.css} | 38 +- .../{ide-bfc53ecd664efbe9896c2b1abcc4b109d436556a21766394407c06a5a5c5f506.css =\> ide-006214ef65e095d41049decc905a5e1555c9171c6a266311c0b88fab2de485c9.css} | 611 +--- .../{import-3f8f87935714a19cea22724b81985adcabdc41fc97be34c2d4c8041ed957425b.css =\> import-8d7666a25f0c93a4a6ee9a8ddd616fcf8de766549b3d34fc580dbb385cbb4120.css} | 8 +- ...4e67a80d1ae2d79170c4cbbb827b80aa142e2f9245313a9ab0f0acc8ce.css =\> incident_management_list-59743aeeeebfd30716677ec235d77696041b209dd88bd29172c96c8433129e8e.css} | 16 +- ...ncidents-5487ca27ad58bc1293fd6f75eb5435da5990e277ab53056734f91b4f8d0324ba.css =\> incidents-c9dd7447d91dc2527085cbbc019ab718f644844d0a36291a8778635274ace7bc.css} | 24 +- ...{issuable-ecd21372e13ff90f684fd5f53fd3087f6c00e41864d7b0f5b11132bf80208ca6.css =\> issuable-8bd0a6368958420c83f4e8afa0d959f0121866f3b8263aefbad9115933d9863a.css} | 51 +- ...list-b5d44ed8fc0a16113e0fcc007fba8ba0f8178739b7064e264cff5d180d9bd9cc.css =\> issuable_list-fb5bdab476a51967681ef7251241bcdf4373454c463f3547a710564ef17a71ea.css} | 43 +- public/assets/page_bundles/issues_analytics-e4d2e523f34a2fa878520cb369ad0583879cfdd6ee803aeb038dd11e49c7378c.css | 769 +++++ ...s_list-ca79a5e69e2f0c3f88546c4e60f14cde2b7797b46db3d6546539eb6725889772.css =\> issues_list-fa42d630fed169947c1924e27ad31981f7e6f89721e822a423c4e78704e475f7.css} | 19 +- ...s_show-e5b2de09eebc5eee4e0b8e225e0595f4f16b526f23884cf6625889ba2420bd83.css =\> issues_show-3bad23cd7b82c46b52a61d46bdc4b946d2694e0ef3d8a748e0bf97ab67f77d71.css} | 28 +- ...nnect-7d4c649f98b987c354507d06caf49ddd70a20c9557e77405838deaee2e3788ff.css =\> jira_connect-58caebfe4adb2545ba52575251d7689319263b0669be20b6cfff6010c56f69b1.css} | 8757 +++++++------------------------------------------ public/assets/page_bundles/labels-30821ca9f1dee82245d92f28b2ac62109860627b82163ea9cc82d07d2225772f.css | 874 +++++ public/assets/page_bundles/labels-ff1e6ce6d5b09b6ca28947e7780c5018fcddf14dfee7d39383c50f2150d475e3.css | 971 ------ public/assets/page_bundles/learn_gitlab-36072b348caacce57ec0dfac15f57a9fa2268c58e43f163b92732db71aff88de.css | 4 - public/assets/page_bundles/learn_gitlab-f615642a8871a1b8e0b9e01c365dda9b7228d2b65d39f4782f404efd8d1aa09f.css | 3 + public/assets/page_bundles/login-52e09bc542400900f3f282fda48de8d166ae5f806b0aa48a1488283434e0f781.css | 1055 ------ .../{signup-a8fa4f3f7e8e13f54118d020d24ebdcc4241dc40c9670f558da5163674b2b6ec.css =\> login-6ba933a5519546ae0bed3976f79c3db5b4417667afe4be968c97ca43450f432e.css} | 122 +- .../{members-aae8491b6ed75a03b5a0414c73dfb894f4c85229367b77bf83535285fce7d305.css =\> members-e718c0cec736c42bd42d5c7336b2ac3d9466a268d6838885e79a4a1853815504.css} | 32 +- ...ts-e4417da2dc8dc2676215f53d1a758905088e9cbde37c2e3ac9efcfe3fa470d06.css =\> merge_conflicts-c454b20565177fa9df04e3a3b7721dc21d98b265a30f01035c29004028d1bfd4.css} | 197 +- ...uest-c846f13f7642d102a72b0794e1c58a5b9f433f37ad62dfcf6516c3358eea5c9b.css =\> merge_request-ca9a87cf5a09a71c45df1785414cfb58e812a4531977061f43ceb7c5a5d41373.css} | 103 +- public/assets/page_bundles/merge_request_analytics-0ffe157505b674217f865255eccb18c3b15552358eea8e8a282c60feb6907f03.css | 769 ----- public/assets/page_bundles/merge_request_analytics-8fe1d4f3a6415de48d42bd2a53bd8d598ba2ca75a819a4128005dc24953b7e2a.css | 764 +++++ ...sts-a5067c9dadf2bcaaf2a031f81145b26698adbdc398ad0c873440ea4bfb489da5.css =\> merge_requests-9c9e16f5f02f9b2dbbb2a69fe246cd84dfdce9c9ed26fd36d51b38029b732025.css} | 372 +-- ...ilestone-cd5bb9dd6c1d641c1ca76078b1b00b3d55b64ffa8654cc6f0f16c40fcc113689.css =\> milestone-df6ddcba5c5e9215f4c2ac85e50d8e3ca7f1ac62074793bda6bacb5abc18fd8c.css} | 76 +- ...b8615a10fbff5f473b68f0b359f4658cd6c7aeb5df67000d810f15ab4ab2.css =\> ml_experiment_tracking-aa5c4d19d725e75c8797c1792f110b49318ad707f96a69770d1c59e974fd96ef.css} | 10 +- ...pace-9e794a2ce449ffbbcc201ce692efb4f4db08b52768e70e5e14864cba40eef8df.css =\> new_namespace-0c182d69c58799f4ea3d33fba9c8111c85a777410959dc99c45e8c62a8c3f5d2.css} | 15 +- ...ions-882349d1431c023715ba45e328d042b9215ed43654427b5c7fa79a46bd79128b.css =\> notifications-1838e4f3ee678915f9bc8755bc1460d9f74a2781778cec478c97d990fdf2c1fe.css} | 7 +- ...s-2185b392d24f5c6d4885ef6fef15db5663490ecc529c2be478c2e5c8696e39ae.css =\> oncall_schedules-485533974c860802917168d88567e28af7b467c3ad8fb16149866c8b39cdb106.css} | 29 +- ...rations-2275623e04274cfd105659f3e6349d4b0d83f79bc67ffd2c9030ed2a4ff84df8.css =\> operations-dbbbf8645b6a50614fdc87488c1269bac093ea6a6c31083e3637e6e6f359f494.css} | 34 +- ...form-4e8d6455742ef11179d46178631ddb29354c7e78ae151c6e9a467207be43db28.css =\> organizations-d7b5112e6812567b697ae5f695433bb4af2d451a2120d9e09a150827e686b88a.css} | 15 +- ...{pipeline-48d30ac764499b59a0ceaee056b5c7e0da7b6cab388fc8738df5b2df235e67d6.css =\> pipeline-481811cd969af3cc9054f0984949c9b016a3e2c6d32046150128a3de939041df.css} | 142 +- ...cs-3bb9df556e7434069d4becec556bf8ce6d437959178c044a2640794d94f07d52.css =\> pipeline_editor-1d951f816f71596c6314b2cc693f26544cd416aa0cf1ef6fcecf4dcc35363198.css} | 41 +- public/assets/page_bundles/pipeline_editor-2c34bc518f9e72fee253a78c3e5892340c4d2e22dc7c2071bce5ca2f5ff1ea51.css | 801 ----- ...ipelines-3a21a6b63b52d9fe410e91f6bc5810cf1a6d6d3934c11f479afe76cb52688f40.css =\> pipelines-aba658cbffb0183c6aa17147eabe7a2502ce93562a9b78f021906b3e37e32629.css} | 77 +- public/assets/page_bundles/productivity_analytics-41d267177b5b6f5dd90ce3e8ba3df4e5341e4fbd37f067dff78f1771739bee3d.css | 865 +++++ public/assets/page_bundles/productivity_analytics-89b2a7fd7a8a0bdbf5efab3f98f89e3454eedc2e4c89ea025f1cf30dbcdaff6a.css | 903 ----- .../{profile-3cddad8551b69b3321c6e11a422dfb30c2832cac0cb81e98a452c6524ae3ac46.css =\> profile-3f0ab77cae859bda4e37a88188d5f5a2fff42442b57284f1b65274fc9d6e1c38.css} | 127 +- ...0486678194a5e1a61290d53598d323772ac90454cb912a85d43bd3cd006.css =\> profile_two_factor_auth-9cc441fef2815a42ed474104d31150f8b3391bd29f3e2ddad7e533d049781f82.css} | 1 - ...rences-580a3df39f9eb6ea9c82c58acd1f359ea49886f2fee44486d6a0b08a91d238eb.css =\> preferences-fd7d256daa7b30338fee5e3c1d5373fc13e70243c935aac8ec0b5a06ef569144.css} | 34 +- .../{project-8bdf8b0f058b542e239ddfa4c72e02a443279a9d674be920db4949ae2c0bd4d2.css =\> project-42ce77f60e4c5f5e78480768375d57b0d0feb161289b90307bb2572469b38ec1.css} | 80 +- ...{projects-b5e72dec43275ec84059267065fb366beb712d5a5b3d32c42a8f1beb2188478e.css =\> projects-6cf439e33b975f784ff513053a4c70f945cad04c0ac52dd82e6ad7a1092427a5.css} | 241 +- public/assets/page_bundles/projects_edit-740ed2a4e4e17e4fb3fea0150cfce3361a984cfe66401f4adc4fc6cdab6d954d.css | 786 ----- ...ions-0a3050e850050fc26db51a8231ddc64622d4ab2607a947fc5af186e5ff980d52.css =\> projects_edit-77b9c8f03474d1e2a5b6b7c2281928e404eaf36c6db3497a148b69642879aab2.css} | 28 +- ...motions-2b1bc5d3dfada50932fc9c24083f4344931e8b13f044ed920d76e8bafc07c22c.css =\> promotions-68bb2c95d257a70e9856446168c86099c5ae1d2adfdb31b4b79fae0d1fa4f169.css} | 22 +- ...{releases-6c559d69f48b22bd33017adf5205a0d5d042a659c2f7b629f559409a008d0f55.css =\> releases-fe7c2bf9c4a39cc4be11f16c80e24bc70b444c0cfd03fa5af8374e777f682852.css} | 11 +- ...bfb49ad5ce931a75d7f8a5ac9a402c01a3a2a2317182520ea7a99015f149ac12.css =\> remote_development-0d3bcbdd811b0cba78fd5fc0f76aaf28ef50fec301965387be67d97586c2b384.css} | 7 +- .../{reports-f6af46357ad26a98effc0fa331315629669e7221e5d99cecda755fe3159c34f5.css =\> reports-08e34086192c3e183e8828dc945715e850b8d663c2df3e822648a63291cd0142.css} | 29 +- ...ments-4121852963c12285782cb769691af44ffd1787686b48bbf807926998cd2653f7.css =\> requirements-e9eb356435a8bcb315633643803b1c8edc36c9c31cb7ecad5b40da9ce205cc0c.css} | 41 +- .../{roadmap-057ba607879b4c9995544e76a048731e10eab0f9f2ef609b26d11b75dc959259.css =\> roadmap-03c499a5cdc4f1d55557dd7df05aff78eae8e3bc7519c3a87cb364ba75c1ec78.css} | 136 +- public/assets/page_bundles/runner_details-6630e8e8e4fec0085c4cdf0acbe0ba6b43a2b2e793b38342a30a9cf308a41d7d.css | 3 + public/assets/page_bundles/runner_details-a84616183b3ab2acabe486661cdbddd95cca3e8ac684a45ca823fe1979414b55.css | 4 - ...ng_details-b1d368851f518d2fc779a8860ff80d862896ed71b0f432a799adc44fb5d7ef3c.css =\> runners-c7a3151b5b8434ebc535049cbbfa33411ac0a29fa79c131b0513dbbb27179647.css} | 42 +- public/assets/page_bundles/runners-d80a5a700420df60cf953590541fbeae0c2ebf0e1d34a86538baaaa55ff3290f.css | 799 ----- .../{search-fc9acc1149dab3a0d71148dd323ac3200f8234cb5a8e0afd219244e3b09bf01c.css =\> search-da7bbd61b67928c7da5500bd4274d3cfb0decb70a782c41e17f6ea8f855c9360.css} | 132 +- ...17b21d893096732a678657609da2a971348049c0e7134e4a858b4cd9b63087bc.css =\> security_dashboard-7d97c2b4985fac2c697f92088cbab9b3bda260ee36e9cfca534076fbe4e52411.css} | 31 +- ...-90fe53bcb5ebd66a53f93429945ae2d16cd3cde560fe0da75449884dcbcf80cf.css =\> security_discover-5154718a094026b2fef794fa20af520a313569098693fe0dacf67e3c88dbc368.css} | 51 +- ...{settings-4abd5069be62d674bdaa2cdbcafbdb5abfa3e2821ffb99f42ce0e2692d5c1a86.css =\> settings-7d5175612c03d8def6605c460fd8462d3439ff4485c0f0d67c1616069111d612.css} | 66 +- public/assets/page_bundles/signup-afd50cb01001211b4e6f94cce7537132549fce2b060a70c74720a178518f8652.css | 785 +++++ public/assets/page_bundles/terminal-b516dfafee44c0d05eecada07168f80f5113767812ed2cfb5a8975270579a2a4.css | 4 - public/assets/page_bundles/terminal-bd582a38b5279e2c08482236467ae85dea38c5d49239305760f4740b4027f6e4.css | 3 + .../{terms-7766f4c1075e643d82815f133de3b3fdd45c62892c2384f01124d69b9fe926f4.css =\> terms-c83ab57ce5658cf30eac9ccb57343d90dbdd4369272b4d71caccb8749d7b412d.css} | 25 +- .../{todos-51584eb6943bebae975d85a25a4ab6c3b6cf08e454f759129fdfad80bc184a13.css =\> todos-54edb9c37e258e3762eddfb1b14b99435a73a158fb6a869d303e0ea2445147aa.css} | 40 +- .../{tree-033c169f7970b336650e4ed41ebf51f6605e730892157ad311a2ba2c57a68be1.css =\> tree-03c738b6bc4a6ba880df7e022178b29db7e870b848e264b41fcaab85bc2def21.css} | 79 +- .../{users-3a9247e43711588e29ea539052b0f5a05646a6705e7c20270958b12b86a098fc.css =\> users-4814e2fe1b1f062a55072ea3eacebd4c75677c48412afac91ca91a386500c8ef.css} | 13 +- ...der-3017b19e36b9066bf866e7df2721192f43bb0b698685eb4827bca13a1ee3c331.css =\> web_ide_loader-34b7226ce979df4128882bcf8ff0ed83bfdfe55b681cc027acde221dbe8b4239.css} | 9 +- .../{wiki-77dc9ec45dc1f163d890f430d85903da6b706de95d19a67bbf790d67613b2d1a.css =\> wiki-5c34c407d75a1654be8dfbeeb9f764900a20889f4bffa8e9016a3d021c4ec359.css} | 250 +- ...k_items-f14dad2007945d2bc39255c185aa9403085a5e98abcab7f8829d22b3b4ee327d.css =\> work_items-d67a6c405c756eb8b2420fd5f9e38e1e9247db91e66897c8b9828fbba33997b2.css} | 116 +- public/assets/page_bundles/xterm-83a8434f75d812750c00eae947de698939b5188349ac92a1c270c106871d2f0f.css | 1677 ---------- public/assets/page_bundles/xterm-af0b971a7d2f1d856360be23266664f91601d4d2f1b002aa9db2677b84d3790c.css | 1091 +++++++ ...ar-49157b722e6580138fe7e07719f36bff66776ab070f6525f2ca76596eb445910.css =\> performance_bar-55b744f1d9b308547802afcee19cae07b6babd21d8eda6cd35029d591c0b4ea3.css} | 69 +- public/assets/print-0206d9a0b89742cfa3514be754f3ce9ba74186e33ded88ea9791ad4798a071cd.css | 789 +++++ public/assets/print-373cb54f5b7c3c3a0a056ff6425e47741da71752ba8ac1f9e63bcc85f51a062d.css | 813 ----- public/assets/snippets-c9f399bb0cd3ab3167ee07e26445160411a9264ff3cc706b089b3f1d931719a9.css | 2185 ------------- public/assets/snippets-dfbe1a77b91a0e8463525fa7508aab20bee1ded153a6bddbcde15be2438e0083.css | 1856 +++++++++++ public/assets/test_environment-b7f6cc5a3b5fa7ca0c3b01b6d9026731917007fcee6dc97e742b4073eea3de95.css | 4 + public/assets/test_environment-d5dd917d26dd8ca70262828cf6d17e0085d148fa7fb3b8f97959b523f497ecbf.css | 5 - public/assets/themes/dark_mode_overrides-991329759d6a1a0afd9c50c0188fd70bf3576327ced8ca229e34e8d1f79d9496.css | 1079 ++++++ public/assets/themes/dark_mode_overrides-be6595a3e4718206e9b962e2e1eef7ff72bc60c470ac1b8212132d4360bfc778.css | 1873 ----------- public/assets/themes/theme_blue-4b14eb9a4f09d12c69684ca0322147a9a35c0daaeacab0fdad3aed297bf529a5.css | 789 ----- public/assets/themes/theme_gray-14a8b0068b027a80103c78373244f793afe27a1969127a2a94030b5af53ad296.css | 789 ----- public/assets/themes/theme_green-b8ce0bc060647deb9c6c5ec1d959c3551c1186903c0a5cde45a182879f6465c9.css | 789 ----- public/assets/themes/theme_indigo-041479d4169036a53999cb13c638193f320161bc04595ab010ffc0ddaea309b5.css | 789 ----- public/assets/themes/theme_light_blue-bd2e1812aae765b8452e4bba4c86b03dea482331b9047f4bc76bc59ac3e52678.css | 789 ----- public/assets/themes/theme_light_gray-e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855.css | 0 public/assets/themes/theme_light_green-4f560347612a5f6bddfa280ab3ede9c4405dacf185f51ba0eece340ef31b6f2d.css | 789 ----- public/assets/themes/theme_light_indigo-c94b411d18b9a320564f178a0d7809dce098eba94098484e1adf6a80108f4e30.css | 789 ----- public/assets/themes/theme_light_red-494ffded68ecc10d008a91e816be4e893ae315b1f2ff96b162155a5bcf79ec72.css | 789 ----- public/assets/themes/theme_red-312cc275ff96a4f21703a292112eeffcd5e84e52d5f61435bf7ff432a3193aff.css | 789 ----- public/assets/webpack/sourcegraph/0.0.91/css/inject.bundle.css | 27 - public/assets/webpack/sourcegraph/0.0.91/css/style.bundle.css | 347 -- public/assets/webpack/sourcegraph/0.0.95/css/app.bundle.css | 1460 +++++++++ public/assets/webpack/sourcegraph/0.0.95/css/contentPage.main.bundle.css | 3804 +++++++++++++++++++++ 144 files changed, 23258 insertions(+), 69319 deletions(-)
NB: This diff happened before I enabled
compressed
output, otherwise the diff looks different as it is all on one lineEdited by Muhammed Ali - I compiled assets with
added 1101 commits
-
1a65cf7d...52a4bd98 - 1089 commits from branch
gitlab-org:master
- 52a4bd98...bdeb3013 - 2 earlier commits
- 27d20bad - Chore: spelling corrections related to Sass/SaaS
- cfa0a290 - Add sassc-rails and ignore cssbundling-rails in CI and deploy
- 4cdd9fff - Make eslint and prettier happy
- 444585a3 - Move from custom file iteration to glob based solution
- 7fa7b620 - Split resolution and compile function
- 9077e0c1 - Add support for JiHu page_bundle styles
- 882994b7 - Implement a --watch mode
- 76ad7559 - Rename compile.mjs to compile_css.mjs
- cd739944 - Allow Cssbundling to be loaded conditionally
- 91f6ea3b - Compress Assets in production, expanded during development
Toggle commit list-
1a65cf7d...52a4bd98 - 1089 commits from branch
mentioned in merge request gitlab-community/gitlab!15 (merged)
added 50 commits
-
91f6ea3b...8699fd91 - 38 commits from branch
gitlab-org:master
- 8699fd91...68c01967 - 2 earlier commits
- e8df183a - Chore: spelling corrections related to Sass/SaaS
- 3937065c - Add sassc-rails and ignore cssbundling-rails in CI and deploy
- a4ee9629 - Make eslint and prettier happy
- 8f9d8b78 - Move from custom file iteration to glob based solution
- 981c9ae1 - Split resolution and compile function
- 96f0c607 - Add support for JiHu page_bundle styles
- a3117093 - Implement a --watch mode
- e6ef8489 - Rename compile.mjs to compile_css.mjs
- 7c68d1b7 - Allow Cssbundling to be loaded conditionally
- f8e682ee - Compress Assets in production, expanded during development
Toggle commit list-
91f6ea3b...8699fd91 - 38 commits from branch
- Resolved by Lukas Eipert
@leipert I'm concious to avoid scope creeping but is it worth it to add a job to compile CSS Bundling assets in CI (but not use them)? It'd just extend
compile-*-assets
but addingUSE_NEW_CSS_PIPELINE: '1'
mentioned in merge request gitlab-development-kit!3537 (merged)
mentioned in commit cdab51c2
mentioned in merge request !141775 (merged)
mentioned in issue #438278 (closed)
- Resolved by Lukas Eipert
@leipert shall i remove
compile_css.mjs
from this MR, and make it just about addingcssbundling-rails
?
- Resolved by Muhammed Ali
- Resolved by Nikhil George
Dependency change review report
⚠ This automation is under testing, please leave your feedback in the issue.Modified Dependency: sassc-rails (2.1.2) Location:
Gemfile.lock
Version diffsChange in dependency identified, pinging @gitlab-com/gl-security/appsec for review. For review guidelines refer handbook page. Hi Appsec, please resolve this thread once review is completed.Checks passed:5/6
⚠ -
ℹ ️ Latest version: 2.1.2 released on: 2019-06-18. URL: https://rubygems.org/gems/sassc-rails -
✅ Latest version is in use. -
✅ Total downloads: 103361921 -
✅ Reverse dependencies: 113 -
✅ Total number of releases: 20 -
⚠ Latest version age (months): 55 -
✅ Source project in Github not archived
-
- Resolved by Muhammed Ali
@ar-mali One thing I dislike about cssbundling, is that it forces a
yarn install
.Wonder if we could overwrite that functionality (e.g. by defining
css:install
as a rake task that does nothing)
4 Warnings ⚠ 7f989fb2: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. ⚠ 9a0ce534: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ⚠ 8c781077: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. ⚠ featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message 📖 This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the
danger-review
job.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @eduardobonet
(UTC+1)
@stanhu
(UTC-8)
database @tianwenchen
(UTC+11)
@tigerwnz
(UTC+8)
frontend @lcallahan
(UTC-7)
@jerasmus
(UTC+1)
~"Tooling" Reviewer review is optional for ~"Tooling" @ankit.panchal
(UTC+5.5)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Rubygems
This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a91ff81a and da57c0f7
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.16 MB 4.16 MB - 0.0 % mainChunk 3.12 MB 3.12 MB - 0.0 %
Note: We do not have exact data for a91ff81a. So we have used data from: a089db67.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 Danger- Resolved by Peter Leitzen
👋 NON-BLOCKING: This MR has changed Gemfile.checksum. GitLab team members should review the following dependency SAST scans when they finish:If there appear to be any true-positive vulnerabilities identified with CRITICAL or HIGH severity, if the report is misconfigured, or if you have questions, reply to this thread and mention
@gitlab-com/gl-security/appsec
.Otherwise, this does not require an AppSec review.
Please also review the Gemfile development AppSec guidelines. Thank you for keeping GitLab secure!
Generated by depSASTer. Open an issue to provide feedback.
🙇 Edited by 🤖 DepSASTer Bot by GitLab AppSec 🤖
- Resolved by Muhammed Ali
@leipert is it worth in a future MR to use async JS in
compile_css.mjs
?
added linked-issue label
added 192 commits
-
0d21b52b...a2f3cf8c - 184 commits from branch
gitlab-org:master
- 4ee628bc - Setup cssbundling-rails
- d93de168 - Add custom Sass compile script to be more configurable
- 9375f180 - Chore: spelling corrections related to Sass/SaaS
- d1aeccc0 - Add sassc-rails and ignore cssbundling-rails in CI and deploy
- 0257ee1b - Allow Cssbundling to be loaded conditionally
- 88cef0db - Compile cssbundling assets in CI
- 3a50f9ce - Remove unneeded script
- 73663dc4 - Add a script to compare sass compilers
Toggle commit list-
0d21b52b...a2f3cf8c - 184 commits from branch
mentioned in commit 98f6006a
- Resolved by Muhammed Ali
@ar-mali !141775 (merged) finally merged. So I think we can get this rebased and finally get this through the review process.
- Resolved by Muhammed Ali
- Resolved by Muhammed Ali
- Resolved by Muhammed Ali
- Resolved by Peter Leitzen
added 198 commits
-
6e893721...2d0f5f86 - 186 commits from branch
gitlab-org:master
- 2d0f5f86...eeb3d594 - 2 earlier commits
- 4478588c - Chore: spelling corrections related to Sass/SaaS
- 9a0ce534 - Add sassc-rails and ignore cssbundling-rails in CI and deploy
- 4f577067 - Allow Cssbundling to be loaded conditionally
- 863dc712 - Compile cssbundling assets in CI
- 6fd442bd - Remove unneeded script
- 7e475840 - Add a script to compare sass compilers
- 7f989fb2 - Remove scripts
- 06bae762 - Bypass Yarn Install during cssbundling
- 8c20bcb3 - Remove Pipeline jobs
- f87aef3f - Clear css:install prereqs to skip yarn install
Toggle commit list-
6e893721...2d0f5f86 - 186 commits from branch
- Resolved by Eduardo Sanz García
@splattael As I already pinged you before, would you mind an initial backend review?
@slashmanov Could you please review frontend?
I do think we can skip the database review, as we just fixed a typo in one of the specs files (
sass
=>saas
).
requested review from @splattael and @slashmanov
removed review request for @leipert
assigned to @leipert
- Resolved by Muhammed Ali
- Resolved by Muhammed Ali
- Resolved by Lukas Eipert
- Resolved by Muhammed Ali
- Resolved by Eduardo Sanz García
- Resolved by Peter Leitzen
- Resolved by Eduardo Sanz García
added security label
- Resolved by Peter Leitzen
- Resolved by Eduardo Sanz García
mentioned in issue gitlab-org/quality/triage-ops#1454 (closed)
added 1 commit
- 1dd1fc55 - Remove rm_rf and undo refactor of prefer_specialized_assets
removed review request for @slashmanov
- Resolved by Lukas Eipert
👋 @slashmanov
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, please start a new pipeline before merging.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
mentioned in issue gitlab-org/frontend/renovate-gitlab-bot#55 (closed)
requested review from @eduardosanz
requested review from @stanhu and removed review request for @splattael
- Resolved by Eduardo Sanz García
added 1 commit
- da2e7835 - Update comment explaining `before_configuration` block
- Resolved by Eduardo Sanz García
- Resolved by Eduardo Sanz García
- Resolved by Eduardo Sanz García
- Resolved by Eduardo Sanz García
@leipert, all looks good! Thanks for the great work! I think it is a great idea to have a tool to compare CSS bundles.
I am curious why did you choose to write the on script in bash and the other in mjs? Why not both in mjs?
- Resolved by Muhammed Ali
- Resolved by Eduardo Sanz García
Dependency change review report
⚠ This automation is under testing, please leave your feedback in the issue.New Dependency: cssbundling-rails (1.3.3) Location:
Gemfile.lock
Checks passed: 6/6
✅ -
ℹ ️ Latest version: 1.3.3 released on: 2023-09-18. URL: https://rubygems.org/gems/cssbundling-rails -
✅ Latest version is in use. -
✅ Total downloads: 3877107 -
✅ Reverse dependencies: 4 -
✅ Total number of releases: 26 -
✅ Latest version age (months): 4 -
✅ Source project in Github not archived
Modified Dependency: sassc-rails (2.1.2) Location:
Gemfile.lock
Version diffsChange in dependency identified, pinging @gitlab-com/gl-security/appsec for review. For review guidelines refer handbook page. Hi Appsec, please resolve this thread once review is completed.Checks passed:5/6
⚠ -
ℹ ️ Latest version: 2.1.2 released on: 2019-06-18. URL: https://rubygems.org/gems/sassc-rails -
✅ Latest version is in use. -
✅ Total downloads: 103688790 -
✅ Reverse dependencies: 113 -
✅ Total number of releases: 20 -
⚠ Latest version age (months): 55 -
✅ Source project in Github not archived
-
- A deleted user
added documentation label
- Resolved by Eduardo Sanz García
- Resolved by Stan Hu
removed review request for @stanhu
- Resolved by Lukas Eipert
enabled an automatic merge when all merge checks for da57c0f7 pass
@leipert, all looks good! Thanks for the great work! I think it is a great idea to have a tool to compare CSS bundles.
I am curious why did you choose to write the on script in bash and the other in mjs? Why not both in mjs?
added pipeline:skip-undercoverage label
@eduardosanz, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
That was "us", adding pipeline:skip-undercoverage. Should have triggered a new pipeline, @eduardosanz.
Hopefully this can be automated: gitlab-org/quality/triage-ops#1459 (closed)
@ar-mali, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
👍 or a👎 on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
❤ This message was generated automatically. You're welcome to improve it.
- React with a
@ar-mali Thank you so much for the iteration on this MR. It's been a pleasure!
@leipert thank you and everyone here, I hope to see this feature through to the end, I've got a halfway decent Webpack integration now working, will be opening a MR soon
@ar-mali Saw your branch and I am sorry, I haven't commented yet on the branch. I think we can simplify it a lotl. Please ping me on the MR.
Edited by Lukas Eipert
mentioned in commit 763aad47
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2763 (merged)