Clean up BE for SecurityConfigurationController
What does this MR do and why?
Clean up BE for SecurityConfigurationController
Clean up BE for SecurityConfigurationController
Remove FF unify_security_configuration
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #350179 (closed)
Merge request reports
Activity
changed milestone to %16.8
assigned to @atiwari71
2 Warnings be1e6ed9: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. e3739ee6: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @imand3r
(UTC-8, 13.5 hours behind author)
@mfangitlab
(UTC-8, 13.5 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@bb5b2a04
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for be1e6ed9expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Package | 15 | 0 | 1 | 0 | 16 | ✅ | | Create | 54 | 0 | 7 | 0 | 61 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 264 | 0 | 9 | 0 | 273 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for be1e6ed9expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Secure | 8 | 0 | 4 | 0 | 12 | ✅ | | Create | 149 | 0 | 16 | 2 | 165 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 183 | 0 | 22 | 2 | 205 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Userremoved Seeking community contributions label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@601a11bb
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@6f050959
- Resolved by Tetiana Chupryna
requested review from @ifrenkel
removed review request for @ifrenkel
- Resolved by Tetiana Chupryna
@hacks4oats Can you give this small MR a first look? Please pass it to Tetiana as she has the context for maintainer review if it looks good.
requested review from @hacks4oats
- Resolved by Tetiana Chupryna
@hacks4oats
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.