Update Gitaly canary storage for staging
What does this MR do and why?
Update Gitaly canary storage for staging
nfs-file-cny01
will soon be obsolete, so we switch to the new canary shard name.
Related to https://gitlab.com/gitlab-com/gl-infra/production-engineering/-/issues/24773
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @ahmadsherif
- A deleted user
added QA label
1 Warning adbad6d9: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer QA @hmuralidhar
(UTC+11, 10 hours ahead of author)
@ddavison
(UTC-5, 6 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@ahmadsherif - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added typemaintenance label
changed milestone to %16.8
requested review from @hmuralidhar
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for adbad6d9expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 0 | 0 | 1 | 0 | 1 | ➖ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 1 | 0 | 1 | ➖ | +--------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for adbad6d9expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 0 | 0 | 4 | 0 | 4 | ➖ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 4 | 0 | 4 | ➖ | +--------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded Quality label
- Resolved by Dan Davison
Change looks good to me! LGTM
requested review from @ddavison and removed review request for @hmuralidhar
- Resolved by Dan Davison
LFTM!
@ahmadsherif - Based on the description:
nfs-file-cny01 will soon be obsolete, so we switch to the new canary shard name.
Question: Do we expect this test to fail in Staging and Staging-Canary until this shard is active?
Edited by Dan Davison
enabled an automatic merge when the pipeline for a8b7bfc1 succeeds