Skip to content
Snippets Groups Projects

Refresh security policies only when user is present in approvers

Merged Sashi Kumar Kumaresan requested to merge sk/fix-refresh-worker into master

What does this MR do and why?

This MR adds an improvement to Security::RefreshProjectPoliciesWorker by not calling Security::ProcessScanResultPolicyWorker if the project's policies does not have user_approvers in YAML. This also adds a feature flag to skip the worker to mitigate incident: gitlab-com/gl-infra/production#17282 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sashi Kumar Kumaresan

Merge request reports

Merged results pipeline #1110771314 passed with warnings

Pipeline: Ruby 3 forced pipeline

#1110772710

    Pipeline: TRIGGERED_EE_PIPELINE

    #1110772836

      Pipeline: GitLab

      #1110772780

        +2

        Merged results pipeline passed with warnings for 5550aa12

        Test coverage 82.54% (8.99%) from 2 jobs

        Merged by Andy SchoenenAndy Schoenen 1 year ago (Dec 18, 2023 8:56am UTC)

        Loading

        Pipeline #1110925787 passed

        Pipeline passed for 46f99d40 on master

        Test coverage 66.89% (8.99%) from 2 jobs

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        Please register or sign in to reply
        Loading