Retire gitlab_enable_admin_mode_sign_in

What does this MR do and why?

Follow up of Speed up admin feature specs (!139400 - merged)

Replace gitlab_enable_admin_mode_sign_in helper for enable_admin_mode!.

This improves the developer experience: It creates a single function to access the admin area, with a parameter to switch between a fast or a slow mode.

I suggest to be reviewed in this fashion:

1. First commit: remove the gitlab_enable_admin_mode_sign_in helper and modify enable_admin_mode!.
2. Second commit: deal with the special cases.
3. Third commit: automatic replacement of all the rest of cases.

Screenshots or screen recordings

N/A

How to set up and validate locally

N/A

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

changed milestone to %16.7

added groupauthentication maintenancerefactor test typemaintenance labels

assigned to @eduardosanz

added devopsgovern sectionsec labels

added 3 commits

• 405099b3 - Retire gitlab_enable_admin_mode_sign_in
• d755d331 - Replace special cases
• d9906177 - Replacement general cases

Compare with previous version

changed the description

added backend label

	2 Warnings
	The merge request title must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	ad0a4f65: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	@a_luna (UTC-5, 6 hours behind author)	@ashmckenzie (UTC+11, 10 hours ahead of author)
test for spec/features/*	@hmuralidhar (UTC+11, 10 hours ahead of author)	Maintainer review is optional for test for spec/features/*

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

@hmuralidhar, @splattael and @ifarkas, please could you review this MR? Thanks!

requested review from @splattael, @ifarkas, and @hmuralidhar

approved this merge request

@splattael, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

added pipeline:mr-approved label

removed review request for @splattael

Generated by gitlab_quality-test_tooling.

---

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#5753044745	spec/features/admin/integrations/instance_integrations_spec.rb#L12	Instance integrations behaves like integration settings form displays all the integrations	176.03 s	< 50.13 s
#5753044921	spec/features/admin/integrations/instance_integrations_spec.rb#L12	Instance integrations behaves like integration settings form displays all the integrations	182.99 s	< 50.13 s
#5753044720	spec/features/issues/keyboard_shortcut_spec.rb#L16	Issues shortcut New Issue shortcut issues are enabled takes user to the new issue page	65.17 s	< 50.13 s
#5753136647	spec/features/admin/integrations/instance_integrations_spec.rb#L12	Instance integrations behaves like integration settings form displays all the integrations	165.15 s	< 50.13 s
#5753097687	spec/features/admin/integrations/instance_integrations_spec.rb#L12	Instance integrations behaves like integration settings form displays all the integrations	164.75 s	< 50.13 s
#5786308474	spec/features/admin/integrations/instance_integrations_spec.rb#L12	Instance integrations behaves like integration settings form displays all the integrations	179.03 s	< 50.13 s
#5786272613	spec/features/admin/integrations/instance_integrations_spec.rb#L12	Instance integrations behaves like integration settings form displays all the integrations	176.02 s	< 50.13 s
#5795211855	spec/features/admin/integrations/instance_integrations_spec.rb#L12	Instance integrations behaves like integration settings form displays all the integrations	144.78 s	< 50.13 s
#5795165990	spec/features/admin/integrations/instance_integrations_spec.rb#L12	Instance integrations behaves like integration settings form displays all the integrations	153.84 s	< 50.13 s
#5795166022	spec/features/admin/admin_disables_git_access_protocol_spec.rb#L23	Admin disables Git access protocol with HTTP disabled shows only SSH url	98.43 s	< 50.13 s
#5795166022	spec/features/admin/admin_disables_git_access_protocol_spec.rb#L37	Admin disables Git access protocol with HTTP disabled mobile component shows only the SSH clone information	98.45 s	< 50.13 s
#5795166022	spec/features/admin/admin_disables_git_access_protocol_spec.rb#L56	Admin disables Git access protocol with SSH disabled shows only HTTP url	97.78 s	< 50.13 s
#5795166022	spec/features/admin/admin_disables_git_access_protocol_spec.rb#L69	Admin disables Git access protocol with SSH disabled mobile component shows only the HTTP clone information	98.41 s	< 50.13 s
#5795166022	spec/features/admin/admin_disables_git_access_protocol_spec.rb#L89	Admin disables Git access protocol with nothing disabled shows default SSH url and protocol selection dropdown	97.44 s	< 50.13 s
#5795166022	spec/features/admin/admin_disables_git_access_protocol_spec.rb#L103	Admin disables Git access protocol with nothing disabled mobile component shows both SSH and HTTP clone information	98.11 s	< 50.13 s

added rspec:slow test detected label

approved this merge request

removed review request for @hmuralidhar