Remove slash_commands feature flag
What does this MR do and why?
This flag has been enabled for a week (#431586 (comment 1679291454))
User can use slash commands in vscode in chat UI.
Changelog: added EE: true
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.7
added backend groupcode creation labels
assigned to @jprovaznik
added devopscreate sectiondev labels
- A deleted user
added featureaddition typefeature labels
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @jtapiab
(UTC-3, 4 hours behind author)
@engwan
(UTC+8, 7 hours ahead of author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@b1ae022f
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for ed6f3422expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 67 | 0 | 0 | 0 | 67 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Create | 54 | 0 | 7 | 0 | 61 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 5 | 0 | 1 | 0 | 6 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 250 | 0 | 10 | 0 | 260 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for ed6f3422expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 551 | 0 | 52 | 4 | 603 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 577 | 0 | 56 | 4 | 633 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost UserSetting label(s) Category:Code Suggestions based on groupcode creation.
added Category:Code Suggestions label
added 182 commits
-
18435588...b5ffc896 - 181 commits from branch
master
- ed6f3422 - Remove slash_commands feature flag
-
18435588...b5ffc896 - 181 commits from branch
- Resolved by Vitali Tatarintev
@ck3g could you please review? Because this is pretty trivial change, perhaps we can skip two-round review, if you agree?
requested review from @ck3g
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c1343839
- Resolved by Vitali Tatarintev
@ck3g
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
enabled an automatic merge when the pipeline for cd3d1c70 succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@cd3d1c70
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@bc91499e
mentioned in commit 56456f25
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2678 (merged)