Change permission for namespace type to read_namespace
requested to merge gitlab-community/gitlab:414993-achievements-awarded-by-public-namespace-hide-the-namespace-name-for-non-members into master
What does this MR do and why?
Namespaces have not been visible on the GraphQL API for users that are not part of the namespace. This is different than it is for groups when they are public. This changes the namespaces to be visible to everyone, if they are public.
Related issues
- Achievements awarded by public namespace hide t... (#414993 - closed)
- Address `read_namespace` semantic disjoint (#421150 - closed)
Screenshots or screen recordings
| before | after |
|---|---|
 |
 |
How to set up and validate locally
bin/rails runner "Feature.enable :achievements"- Have achievements (either already seeded or
bin/rake db:seed_fu FILTER=36_achievements - Find a user that has achievements (Rails console)
ua = Achievements::UserAchievement.first puts ua.achievement.namespace.full_path puts ua.user.username - Impersonate a user that is not a member of the group
- Visit the profile of the user and verify that the group name appears in the tooltip of the achievement
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Lee Tickett