Add trigger indexing worker
What does this MR do and why?
Related to #434590 (closed)
Behind a feature flag
Makes the gitlab:elastic:index
rake task asynchronous through a new worker
Screenshots or screen recordings
N/A
How to set up and validate locally
- setup gdk for elasticsearch
- start elasticsearch
gdk start elasticsearch
- index everything, this will use the old method
bundle exec rake gitlab:elastic:index
- Go to Admin Area > Settings > Advanced Search to enable Elasticsearch.
-
Elasticsearch indexing
andSearch with Elasticsearch enabled
should be checked
-
- confirm search works and is using Advanced search (should see a message:
Advanced search is enabled
) - enable the feature flag
echo "Feature.enable(:elastic_index_use_trigger_indexing)" | gdk rails c
- re-run the rake task
bundle exec rake gitlab:elastic:index
- confirm the worker runs successfully in the sidekiq logs
- can also check status in **Admin Area > Settings > Advanced Search > Indexing status
- confirm search works and is using Advanced search (should see a message:
Advanced search is enabled
)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added groupglobal search typemaintenance labels
assigned to @dgruzd
added devopsdata stores sectioncore platform labels
- A deleted user
added backend label
1 Warning 6a9839eb: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @thutterer
(UTC+1, same timezone as author)
@michold
(UTC+1, same timezone as author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Sidekiq queue changes
This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.
These queues were added:
search_elastic_trigger_indexing
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- A deleted user
added feature flag label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@ac208089
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@21912bcd
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 213e0404expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 64 | 0 | 3 | 0 | 67 | ✅ | | Plan | 51 | 0 | 3 | 0 | 54 | ✅ | | Verify | 29 | 0 | 2 | 0 | 31 | ✅ | | Create | 45 | 0 | 17 | 0 | 62 | ✅ | | Package | 15 | 0 | 1 | 0 | 16 | ✅ | | Data Stores | 20 | 0 | 3 | 0 | 23 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 238 | 0 | 30 | 0 | 268 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for af22f4acexpand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Plan | 246 | 0 | 13 | 3 | 259 | ✅ | | Fulfillment | 8 | 0 | 69 | 0 | 77 | ✅ | | Govern | 277 | 0 | 20 | 7 | 297 | ✅ | | Package | 226 | 0 | 17 | 0 | 243 | ✅ | | Create | 550 | 0 | 67 | 8 | 617 | ✅ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 7 | 0 | 0 | 0 | 7 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Verify | 138 | 0 | 27 | 6 | 165 | ✅ | | Manage | 39 | 1 | 10 | 4 | 50 | ❌ | | Monitor | 36 | 0 | 13 | 0 | 49 | ✅ | | Data Stores | 113 | 0 | 7 | 0 | 120 | ✅ | | Configure | 1 | 0 | 9 | 0 | 10 | ✅ | | Secure | 6 | 0 | 3 | 0 | 9 | ✅ | | ModelOps | 0 | 0 | 8 | 0 | 8 | ➖ | | Release | 15 | 0 | 3 | 0 | 18 | ✅ | | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 1672 | 1 | 273 | 28 | 1946 | ❌ | +----------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Usercc @terrichu
I believe this worker can help with Support all projects indexed in elastic rake (!138098 - merged)
changed milestone to %Backlog
changed milestone to %16.7
added 2 commits
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@7f24d31e