Move DependencyProxyUsage to CE
What does this MR do and why?
This is the third of a series of MRs that aim to migrate the Namespace Storage Vue App to CE so that this view is available for all GitLab Editions and Distributions. Related to: Move storage app to CE (#371824 - closed)
Here we move DependencyProxyUsage
and its tests to the CE directory.
MR Cadence
Description | MR |
---|---|
Introduce NamespaceStorageApp in core | !138689 (merged) |
Create StorageUsageStatistics in CE | !139111 (merged) |
Move DependencyProxyUsage to CE |
![]() |
Move ContainerRegistryUsage to CE | !139252 (merged) |
Move Usage Quotas test fixtures to CE | !142067 (merged) |
Move SearchAndSortBar to CE | !139434 (merged) |
Move ProjectList to CE | !139449 (merged) |
Finish moving NamespaceStorageApp to CE | !139568 (merged) |
Replace placeholder with NamespaceStorageApp | !140209 (closed) |
Screenshots or screen recordings
All the changes here are behind a Feature Flag: usage_quotas_for_all_editions
, so there should be no UI or behavior change for now.
How to set up and validate locally
We need to validate this in 4 scenarios:
- GitLab EE Unlicensed: this is probably how your GDK is right now. If you have a license in your GDK, remove it in https://gdk.test:3443/admin/subscription
- GitLab EE: by having a test license in your GDK.
- GitLab SaaS: setup a license like the above and simulate SaaS
-
GitLab CE: by executing
export FOSS_ONLY=1
gdk restart
- Tanuki gdk website icon (the one in the browser tab) should be blue, then you're in
CE
Now go to any Group Usage Quotas: https://gdk.test:3443/groups/flightjs/-/usage_quotas and check if your local setup matches the expected behavior.
- To enable the FF:
Feature.enable(:usage_quotas_for_all_editions)
- To disable the FF:
Feature.disable(:usage_quotas_for_all_editions)
Expected behavior:
- Expected behavior with Feature Flag on: Page loads a placeholder (
storage_app_placeholder
) for all the scenarios.
GitLab Distribution | Expected behavior FF off |
---|---|
GitLab EE Unlicensed | Renders a 404 page |
GitLab EE | Loads the page normally, hiding SaaS UI (e.g. the right hand side card in Namespace overview) |
GitLab SaaS | Page loads normally, like it is on master /GitLab.com
|
GitLab CE | Renders a 404 page |
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @sheldonled
- A deleted user
added frontend label
3 Warnings f0326c1c: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.1 Message This merge request includes changes to Vue files that have both CE and EE versions. Vue
<template>
in CE and EESome Vue files in CE have a counterpart in EE. (For example,
path/to/file.vue
andee/path/to/file.vue
.)When run in the context of CE, the
<template>
of the CE Vue file is used. When run in the context of EE, the<template>
of the EE Vue file is used.It's easy to accidentally make a change to a CE
<template>
that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:
app/assets/javascripts/usage_quotas/storage/components/namespace_storage_app.vue
app/assets/javascripts/usage_quotas/storage/components/dependency_proxy_usage.vue
If you made a change to the
<template>
of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.A better alternative
An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/ee/development/ee_features.html#template-tag
testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/usage_quotas/storage/components/namespace_storage_app.vue
+ <h3 data-testid="breakdown-subtitle">
ee/app/assets/javascripts/usage_quotas/storage/components/namespace_storage_app.vue
- <h3 data-testid="breakdown-subtitle">
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start thetrigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure the tests infollow-up-e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend @jrushford
(UTC+1, 1 hour ahead of author)
@pgascouvaillancourt
(UTC-5, 5 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@sheldonled - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for f0326c1cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Create | 54 | 0 | 7 | 0 | 61 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Govern | 74 | 0 | 0 | 0 | 74 | ✅ | | Package | 4 | 0 | 1 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 255 | 0 | 9 | 0 | 264 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost UserSetting label grouputilization based on
@sheldonled
's group.added grouputilization label
Setting label(s) Category:Consumables Cost Management devopsfulfillment sectionfulfillment based on grouputilization.
mentioned in merge request !138689 (merged)
mentioned in merge request !139111 (merged)
added 1607 commits
-
e818482f...8a786bd0 - 1606 commits from branch
led/371824-move-storage-usage-overview-to-ce
- 6f0edaa9 - Move DependencyProxyUsage to CE
-
e818482f...8a786bd0 - 1606 commits from branch
added maintenancerefactor typemaintenance labels
mentioned in merge request !139252 (merged)
mentioned in merge request !139434 (merged)
mentioned in merge request !139449 (merged)
mentioned in merge request !139568 (merged)
mentioned in merge request !140209 (closed)