Skip to content

Add Max Role Column To Users List on Code Suggestions Tab

Angelo Gulina requested to merge ag/422788-add-max-role-column into master

What does this MR do and why?

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/422788. With this MR, we are introducing a new column to the AddOnEligibleUserList component. In particular, the new column will only be visible when:

  1. enableAddOnUsersFiltering is enabled
  2. at least one user has a maxRole field

Note that the feature does not impact current UI, as the FF is disabled.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

w/ Max Role w/out Max Role
Screenshot 2023-12-18 at 20.10.36.png Screenshot 2023-12-18 at 20.10.02.png

How to set up and validate locally

  1. Needs both gdk and CustomersDot running (setup guide)
  2. In Rails console, enable Code Suggestions Feature.enable(:hamilton_seat_management)
  3. In Rails console, enable the filtering capabilities Feature.enable(:enable_add_on_users_filtering)

To assign Code Suggestions seats to your group:

  1. In Rails console, add_on = GitlabSubscriptions::AddOn.find_or_create_by!(name: "code_suggestions") {|e| e.description = "Test"}
  2. In Rails console, GitlabSubscriptions::AddOnPurchase.create!(add_on: add_on, namespace: Namespace.find(<you-name-space-id>), expires_on: 21.month.from_now, quantity: 5, purchase_xid: 'A-S0002')
  3. Visit any group or project member pages such as http://127.0.0.1:3000/groups/flightjs/-/usage_quotas#code-suggestions-usage-tab

To have users with MaxRole:

  1. update the tableItems adding the maxRole field in the mapped array

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Angelo Gulina

Merge request reports