Skip to content
Snippets Groups Projects

Revert "Merge branch 'jennli-quarantine-issue-433187' into 'master'"

Merged Jay McCure requested to merge revert-7ca7c590 into master

What does this MR do and why?

De-quarantines push_over_ssh_spec.rb from review-apps, as review-apps infra issue is resolved.

Resolves #433030 (closed)

I had to add a dummy commit so the test would run in a pipeline, we can see the passing test result here: https://gitlab-qa-allure-reports.s3.amazonaws.com/e2e-review-qa/revert-7ca7c590/1102068173/index.html#suites/969b4f4cc5161df328240a6d47f06702/f9964f4bdd24bbff/ (i've now removed the dummy commit)

Debugging information for the failure can be found: #433030 (comment 1672787097)

Revert "Merge branch 'jennli-quarantine-issue-433187' into 'master'"

This reverts merge request !138241 (merged)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jay McCure

Merge request reports

Merged results pipeline #1107404744 passed

Pipeline: TRIGGERED_EE_PIPELINE

#1107408721

    Pipeline: E2E GDK

    #1107407362

      Pipeline: E2E Omnibus GitLab EE

      #1107443211

        Merged results pipeline passed for fb0f6a29

        Merged by Tiffany ReaTiffany Rea 1 year ago (Dec 14, 2023 6:38pm UTC)

        Loading

        Pipeline #1107460718 passed

        Pipeline passed for 43186bbb on master

        10 environments impacted.

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
        • assigned to @jay_mccure

        • 👋 @jay_mccure,

          To speed up your revert merge request, please consider using the revert merge request template. Adding the appropriate labels for resolving master:broken before the merge request is created will skip several CI/CD jobs.

          For this merge request, if this is for resolving master:broken you can add the appropriate labels present in the merge request template, and trigger a new pipeline. It will be faster 🚀.

          See the docs.

        • A deleted user added QA label

          added QA label

        • 2 Warnings
          In a revert merge request? Use the revert merge request template to add labels that skip changelog checks.

          Reverting something in the current milestone? A changelog isn't required. Skip changelog checks by adding ~"regression:*" label, then re-run the danger job (there is a link at the bottom of this comment).

          ad2a1757: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
          1 Message
          📖 CHANGELOG missing:

          If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

          If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

          Reviewer roulette

          Changes that require review have been detected!

          Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

          Category Reviewer Maintainer
          QA @hmuralidhar profile link current availability (UTC+11, 1 hour ahead of author) @acunskis profile link current availability (UTC+2, 8 hours behind author)

          Please check reviewer's status!

          • available Reviewer is available!
          • unavailable Reviewer is unavailable!

          Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

          To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

          Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

          If needed, you can retry the 🔁 danger-review job that generated this comment.

          Generated by 🚫 Danger

          Edited by Ghost User
        • E2E Test Result Summary

          allure-report-publisher generated test report!

          e2e-test-on-gdk: test report for 5a2a9c64

          expand test summary
          +-------------------------------------------------------------+
          |                       suites summary                        |
          +--------+--------+--------+---------+-------+-------+--------+
          |        | passed | failed | skipped | flaky | total | result |
          +--------+--------+--------+---------+-------+-------+--------+
          | Create | 2      | 0      | 0       | 0     | 2     | ✅     |
          +--------+--------+--------+---------+-------+-------+--------+
          | Total  | 2      | 0      | 0       | 0     | 2     | ✅     |
          +--------+--------+--------+---------+-------+-------+--------+

          e2e-package-and-test: test report for 5a2a9c64

          expand test summary
          +-------------------------------------------------------------+
          |                       suites summary                        |
          +--------+--------+--------+---------+-------+-------+--------+
          |        | passed | failed | skipped | flaky | total | result |
          +--------+--------+--------+---------+-------+-------+--------+
          | Create | 8      | 0      | 0       | 0     | 8     | ✅     |
          +--------+--------+--------+---------+-------+-------+--------+
          | Total  | 8      | 0      | 0       | 0     | 8     | ✅     |
          +--------+--------+--------+---------+-------+-------+--------+

          e2e-review-qa: test report for ad2a1757

          expand test summary
          +-----------------------------------------------------------------------+
          |                            suites summary                             |
          +------------------+--------+--------+---------+-------+-------+--------+
          |                  | passed | failed | skipped | flaky | total | result |
          +------------------+--------+--------+---------+-------+-------+--------+
          | Create           | 8      | 0      | 2       | 2     | 10    | ❗     |
          | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
          | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
          | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
          | Govern           | 3      | 0      | 0       | 0     | 3     | ✅     |
          | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
          | Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
          +------------------+--------+--------+---------+-------+-------+--------+
          | Total            | 20     | 0      | 5       | 2     | 25    | ❗     |
          +------------------+--------+--------+---------+-------+-------+--------+
          Edited by Ghost User
        • Setting label(s) Quality based on QA.

        • Jay McCure added 1 commit

          added 1 commit

          • ad2a1757 - Update user_merge_request_interaction_type.rb

          Compare with previous version

        • A deleted user added backend label

          added backend label

        • Jay McCure
      • Jay McCure added 1 commit

        added 1 commit

        • 5a2a9c64 - Apply 1 suggestion(s) to 1 file(s)

        Compare with previous version

      • Jay McCure resolved all threads

        resolved all threads

      • Jay McCure marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

        marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

      • Jay McCure changed the description

        changed the description

      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Loading
      • Please register or sign in to reply
        Loading