Remove unused `MAX_DAYS_OF_HISTORY` from vulnerabilities
What does this MR do and why?
The MAX_DAYS_OF_HISTORY
constant in the vulnerability
model
appears to be unused:
~/gitlab-development-kit/gitlab$ ag --ignore TAGS \
--literal \
--group \
--line-number \
--column \
--smart-case -- MAX_DAYS_OF_HISTORY .
File: ee/app/models/ee/vulnerability.rb
22:7: MAX_DAYS_OF_HISTORY = 10
1 matches
1 files contained matches
62376 files searched
git history
- added in 7ff151eb
- used in
VulnerabilitiesHistoryResolver
andVulnerability.counts_by_day_and_severity
- used in
-
VulnerabilitiesHistoryResolver
removed in 89009fc7 -
Vulnerability.counts_by_day_and_severity
removed in e9567195
resolves: #433494 (closed)
How to set up and validate locally
- ci passes
- run a similar search as the
ag
above
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #433494 (closed)
Merge request reports
Activity
changed milestone to %16.7
added devopsgovern groupthreat insights maintenanceremoval sectionsec typemaintenance workflowin dev + 1 deleted label
assigned to @wandering_person
added 1 commit
- d2844755 - Remove unused `MAX_DAYS_OF_HISTORY` from vulnerabilities
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- A deleted user
added backend label
- Resolved by Jarka Košanová
2 Warnings ⚠ d2844755: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. ⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message 📖 CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @jnutt
(UTC+8, 1 hour ahead of author)
@jarka
(UTC+1, 6 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by Ghost User
requested review from @jnutt
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
✅ test report for d2844755expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 52 | 0 | 9 | 0 | 61 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 226 | 0 | 12 | 0 | 238 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
❗ test report for d2844755expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Govern | 289 | 0 | 23 | 3 | 312 | ❗ | | Create | 131 | 0 | 12 | 0 | 143 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 420 | 0 | 35 | 3 | 455 | ❗ | +--------+--------+--------+---------+-------+-------+--------+
Edited by Ghost User- Resolved by Jarka Košanová
👋 @jnutt
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
Thanks @wandering_person , looks good to me. MWPS set
🚀 enabled an automatic merge when the pipeline for bd9c9170 succeeds
mentioned in commit 5053b4c4
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label