Skip to content

Switch to optional CODEOWNER sections

Thong Kuah requested to merge meta_optional_codeowner_approvals into master

What does this MR do and why?

Switch to optional CODEOWNER sections.

For efficiency and for ease of iteration, we switch mandatory CODEOWNER sections to become optional. Some mandatory sections were kept for compliance, security, or availability reasons.

Document the thinking about this.

Related issue: #377326

Why?

  1. Having a large number of required approvers on a merge request is not efficient.
  2. As we have a non-modular monolith, more and more mandatory sections is not scalable. Having a modular monolith is probably years away.

For example, on !136642 (merged), we had 5 required approvers:

screenshot

Screenshot_2023-12-04_at_9.59.47_PM

See also related Slack thread (internal)

Why not ?

Alternatives to this MR

Edited by Thong Kuah

Merge request reports