Add Accordion for Experimental Settings (New Project)
What does this MR do and why?
Adds an Accordion component and uses it on the New Project page to wrap experimental settings.
Contributes to #433130 (closed)
Screenshots or screen recordings
How to set up and validate locally
- Enable the
support_sha256_repositories
feature flag. - Visit create new project page (http://gdk.test:3000/projects/new#blank_project)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.7
added backend featureaddition frontend groupsource code labels
assigned to @vyaklushin
added typefeature label
added devopscreate sectiondev labels
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @rkumar555
(UTC+1, same timezone as author)
@sashi_kumar
(UTC+0, 1 hour behind author)
frontend @dstull
(UTC-5, 6 hours behind author)
@eduardosanz
(UTC+1, same timezone as author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermentioned in issue #433130 (closed)
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1c277c98expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Create | 52 | 0 | 9 | 0 | 61 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 226 | 0 | 12 | 0 | 238 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost UserSetting label(s) Category:Source Code Management based on groupsource code.
added Category:Source Code Management label
added UX component:accordion labels
- Resolved by Jacques Erasmus
Thank you for working on this @vyaklushin
I am happy to help with the UX review when this is ready
changed milestone to %16.8
added missed:16.7 label
changed milestone to %16.9
added missed:16.8 label
assigned to @jerasmus