Skip to content
Snippets Groups Projects

Group deps: Fix issue with long project names

What does this MR do and why?

Group deps: Fix issue with long project names

When a project name is too long, it wraps incorrectly within the filter option. This change fixes this.

Screenshots or screen recordings

Before After
unchecked Screenshot_2023-12-01_at_10.06.16_am Screenshot_2023-12-01_at_10.06.45_am
checked Screenshot_2023-12-01_at_10.06.22_am Screenshot_2023-12-01_at_10.06.35_am

How to set up and validate locally

  1. Go to a group's dependency list (make sure that it contains at least one project with a long name)
  2. Select the project filter
  3. Verify that the filter options render correctly

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #433246 (closed)

Edited by David Pisek

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Pisek changed milestone to %16.7

    changed milestone to %16.7

  • assigned to @dpisek

  • 1 Warning
    :warning: You've made some app changes, but didn't add any tests.
    That's OK as long as you're refactoring existing code,
    but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.
    1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend @jmontal profile link current availability (UTC-7, 8 hours behind author) @deepika.guliani profile link current availability (UTC+5.5, 4.5 hours ahead of author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits dc2be3a0 and 61b91ab0

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.1 MB 4.1 MB - 0.0 %
    mainChunk 3.04 MB 3.04 MB - 0.0 %

    Note: We do not have exact data for dc2be3a0. So we have used data from: d107f33c.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 61b91ab0

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 52     | 0      | 9       | 0     | 61    | ✅     |
    | Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
    | Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Verify           | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Govern           | 57     | 0      | 0       | 0     | 57    | ✅     |
    | Monitor          | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Data Stores      | 23     | 0      | 0       | 0     | 23    | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 226    | 0      | 12      | 0     | 238   | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :exclamation: test report for 61b91ab0

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Govern | 288    | 0      | 23      | 3     | 311   | ❗     |
    | Create | 131    | 0      | 12      | 0     | 143   | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 419    | 0      | 35      | 3     | 454   | ❗     |
    +--------+--------+--------+---------+-------+-------+--------+

    e2e-review-qa: :white_check_mark: test report for 61b91ab0

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 6      | 0      | 4       | 0     | 10    | ✅     |
    | Govern           | 51     | 0      | 2       | 0     | 53    | ✅     |
    | Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 66     | 0      | 9       | 0     | 75    | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    Edited by Ghost User
  • David Pisek changed the description

    changed the description

  • David Pisek
  • requested review from @lorenzvanherwaarden

  • David Pisek marked this merge request as ready

    marked this merge request as ready

  • closed

  • reopened

  • Lorenz van Herwaarden approved this merge request

    approved this merge request

  • removed review request for @lorenzvanherwaarden

  • David Pisek requested review from @svedova

    requested review from @svedova

  • David Pisek added 263 commits

    added 263 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading