Group deps: Fix issue with long project names
What does this MR do and why?
Group deps: Fix issue with long project names
When a project name is too long, it wraps incorrectly within the filter option. This change fixes this.
Screenshots or screen recordings
Before | After | |
---|---|---|
unchecked | ![]() |
![]() |
checked | ![]() |
![]() |
How to set up and validate locally
- Go to a group's dependency list (make sure that it contains at least one project with a long name)
- Select the project filter
- Verify that the filter options render correctly
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #433246 (closed)
Merge request reports
Activity
changed milestone to %16.7
assigned to @dpisek
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend @jmontal
(UTC-7, 8 hours behind author)
@deepika.guliani
(UTC+5.5, 4.5 hours ahead of author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits dc2be3a0 and 61b91ab0
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.1 MB 4.1 MB - 0.0 % mainChunk 3.04 MB 3.04 MB - 0.0 %
Note: We do not have exact data for dc2be3a0. So we have used data from: d107f33c.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 61b91ab0expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 52 | 0 | 9 | 0 | 61 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 226 | 0 | 12 | 0 | 238 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 61b91ab0expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Govern | 288 | 0 | 23 | 3 | 311 | ❗ | | Create | 131 | 0 | 12 | 0 | 143 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 419 | 0 | 35 | 3 | 454 | ❗ | +--------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 61b91ab0expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 6 | 0 | 4 | 0 | 10 | ✅ | | Govern | 51 | 0 | 2 | 0 | 53 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 66 | 0 | 9 | 0 | 75 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost User- Resolved by Savas Vedova
- Resolved by David Pisek
@lorenzvanherwaarden - Could you please review?
requested review from @lorenzvanherwaarden
- Resolved by Savas Vedova
@lorenzvanherwaarden
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
removed review request for @lorenzvanherwaarden
- Resolved by David Pisek
@svedova - Could you please maintainerize this small one?
requested review from @svedova
added 263 commits
-
251a1382...3a0cc41e - 262 commits from branch
master
- 61b91ab0 - Group deps: Fix issue with long project names
-
251a1382...3a0cc41e - 262 commits from branch