Adds backend project setting for model registry
What does this MR do and why?
This MR addresses the first part of Add feature toggle for Model registry (#412734 - closed) by adding the attribute to the database and the configuration for the Model Registry feature setting.
How to set up and validate locally
- Run migrations
- on rails console, run the command below. It should return 20
Project.first.model_experiments_access_level
Database Review
Up
main: == [advisory_lock_connection] object_id: 184060, pg_backend_pid: 11065
main: == 20231130195635 AddModelRegistryAccessLevelToProjectFeature: migrating ======
main: -- add_column(:project_features, :model_registry_access_level, :integer, {:null=>false, :default=>20})
main: -> 0.0026s
main: == 20231130195635 AddModelRegistryAccessLevelToProjectFeature: migrated (0.0062s)
main: == [advisory_lock_connection] object_id: 184060, pg_backend_pid: 11065
Down
main: == [advisory_lock_connection] object_id: 184060, pg_backend_pid: 10462
main: == 20231130195635 AddModelRegistryAccessLevelToProjectFeature: reverting ======
main: -- remove_column(:project_features, :model_registry_access_level, :integer, {:null=>false, :default=>20})
main: -> 0.0026s
main: == 20231130195635 AddModelRegistryAccessLevelToProjectFeature: reverted (0.0087s)
main: == [advisory_lock_connection] object_id: 184060, pg_backend_pid: 10462
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.7
assigned to @darbyfrey
mentioned in commit a09dbe99
added 1 commit
- a09dbe99 - Adds backend project setting for model registry
- Resolved by Adam Hegyi
@eduardobonet want to give this one an initial review?
requested review from @eduardobonet
mentioned in issue #412734 (closed)
- A deleted user
added backend documentation labels
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.a09dbe99: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/administration/audit_event_streaming/audit_event_types.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @j_lar
(UTC+1)
@acook.gitlab
(UTC-5)
database @jarka
(UTC+1)
@Quintasan
(UTC+1)
groupcompliance Reviewer review is optional for groupcompliance @ahuntsman
(UTC-6)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
- A deleted user
added Data WarehouseImpact Check label
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for a09dbe99expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Create | 54 | 0 | 7 | 0 | 61 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 228 | 0 | 10 | 0 | 238 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Adam Hegyi
requested review from @acook.gitlab and removed review request for @eduardobonet
- Resolved by Adam Hegyi
@eduardobonet
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
Setting label(s) Category:MLOps based on groupmlops.
added Category:MLOps label
requested review from @carlad-gl
added Data WarehouseNot Impacted label and removed Data WarehouseImpact Check label
removed review request for @acook.gitlab
requested review from @ahegyi and removed review request for @carlad-gl
added databaseapproved label and removed databasereview pending label
Database migrations (on the main database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20231130195635 - AddModelRegistryAccessLevelToProjectFeature Regular 2.3 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 5 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20231130195635 - AddModelRegistryAccessLevelToProjectFeature
- Type: Regular
- Duration: 2.3 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 1 45.1 ms 45.1 ms 45.1 ms 0 ALTER TABLE "project_features" ADD "model_registry_access_level" integer DEFAULT 20 NOT NULL
1 1.3 ms 1.3 ms 1.3 ms 1 SELECT "feature_gates"."key", "feature_gates"."value" FROM "feature_gates" WHERE "feature_gates"."feature_key" = $1
1 0.0 ms 0.0 ms 0.0 ms 1 SELECT $1::regtype::oid
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
Histogram for AddModelRegistryAccessLevelToProjectFeature
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 5 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
No other migrations pending on GitLab.com
Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-2596691-12097558-main
2023-12-04T11:01:00Z 2023-12-04T08:10:14Z 2023-12-04 23:05:05 +0000 database-testing-2596691-12097558-ci
2023-12-04T11:01:00Z 2023-12-04T08:44:15Z 2023-12-04 23:05:05 +0000 Database migrations (on the ci database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20231130195635 - AddModelRegistryAccessLevelToProjectFeature Regular 3.2 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 3 0.1 seconds - 1 second 1 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20231130195635 - AddModelRegistryAccessLevelToProjectFeature
- Type: Regular
- Duration: 3.2 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 1 81.7 ms 81.7 ms 81.7 ms 0 ALTER TABLE "project_features" ADD "model_registry_access_level" integer DEFAULT 20 NOT NULL
1 0.0 ms 0.0 ms 0.0 ms 1 SELECT $1::regtype::oid
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
Histogram for AddModelRegistryAccessLevelToProjectFeature
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 3 0.1 seconds - 1 second 1 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
No other migrations pending on GitLab.com
Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-2596691-12097558-main
2023-12-04T11:01:00Z 2023-12-04T08:10:14Z 2023-12-04 23:05:05 +0000 database-testing-2596691-12097558-ci
2023-12-04T11:01:00Z 2023-12-04T08:44:15Z 2023-12-04 23:05:05 +0000
Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic
- Resolved by Darby Frey
Hi, @sam.figueroa! Could you do the audit event review?
requested review from @sam.figueroa
- A deleted user
added database-testing-automation label
enabled an automatic merge when the pipeline for 9dd7e9f4 succeeds
Hello @darbyfrey
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
mentioned in commit 060a7794
added workflowstaging-canary label
mentioned in commit 8f2c2253
added workflowcanary label and removed workflowstaging-canary label
added workflowproduction label and removed workflowcanary label
added workflowstaging label and removed workflowproduction label
added workflowpost-deploy-db-staging label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-com/www-gitlab-com#34769 (closed)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2678 (merged)
mentioned in issue #440955