GraphQL API to delete instance Amazon S3 configurations
What does this MR do and why?
GraphQL API for deleting instance Amazon S3 configurations
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Visit GraphiQL explorer
https://gdk.test:3000/-/graphql-explorer
- Run the following mutation to create a new
AuditEvents::Instance::AmazonS3Configuration
and also note down theid
.
mutation createInstanceAmazonS3Configuration {
auditEventsInstanceAmazonS3ConfigurationCreate(input: {name: "AWS S3 Sanbox Instance", awsRegion: "us-east-1", accessKeyXid: "AKIA1234AKIA1234", secretAccessKey: "SECRET123SECRET123", bucketName: "gitlab-audit-logs"}) {
errors,
instanceAmazonS3Configuration{
id,
name,
bucketName,
accessKeyXid,
awsRegion
}
}
- Run
AuditEvents::Instance::AmazonS3Configuration.last
in rails console and verify that a new instance Amazon S3 configuration is created. - Run the following graphQL query to delete the above record
mutation deleteInstanceAmazonS3Configuration {
auditEventsInstanceAmazonS3ConfigurationDelete(input: {id: "gid://gitlab/AuditEvents::Instance::AmazonS3Configuration/7"}) {
errors
}
}
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #423235 (closed)
Merge request reports
Activity
changed milestone to %16.7
added GraphQL backend featureaddition groupcompliance labels
assigned to @huzaifaiftikhar1
added typefeature label
added devopsgovern sectionsec labels
added 1 commit
- 530c3f4f - Add GraphQL API to delete instance Amazon S3 configurations
added 1 commit
- 75f9fdc0 - Add GraphQL API to delete instance Amazon S3 configurations
mentioned in issue #423235 (closed)
- A deleted user
added documentation label
- Resolved by euko
1 Warning 0666d9b9: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/administration/audit_event_streaming/audit_event_types.md
(Link to current live version) -
doc/api/graphql/reference/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @eduardobonet
(UTC+1, 4.5 hours behind author)
@stanhu
(UTC-8, 13.5 hours behind author)
groupcompliance Reviewer review is optional for groupcompliance @jmontal
(UTC-7, 12.5 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
- Resolved by Harsimar Sandhu
@theoretick Can you please perform the initial backend review?
requested review from @theoretick
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 0666d9b9expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Create | 54 | 0 | 7 | 0 | 61 | ✅ | | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 228 | 0 | 10 | 0 | 238 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 0666d9b9expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 292 | 0 | 23 | 3 | 315 | ❗ | | Create | 141 | 0 | 14 | 0 | 155 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 443 | 0 | 39 | 3 | 482 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 3313c1d8 - Add GraphQL API to delete instance Amazon S3 configurations
- Resolved by Evan Read
@eread Can you please perform the documentation review?
requested review from @eread
- Resolved by euko
@theoretick
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
requested review from @eread and removed review request for @theoretick
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
removed review request for @eread
added Technical Writing docsfeature labels
requested review from @eread
removed review request for @eread
requested review from @euko
added databaseapproved label
removed review request for @euko
- Resolved by Harsimar Sandhu
@harsimarsandhu Can you please perform groupcompliance review?
requested review from @harsimarsandhu
removed review request for @brodock
added 1309 commits
-
2300f9d9...dd95ea01 - 1307 commits from branch
master
- 6a3956f5 - Add GraphQL API to delete instance Amazon S3 configurations
- 0666d9b9 - Update docs
-
2300f9d9...dd95ea01 - 1307 commits from branch
requested review from @euko
removed review request for @euko
@harsimarsandhu, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
Hello @huzaifaiftikhar1
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
mentioned in commit ec6b0cec
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2678 (merged)