Skip to content
Snippets Groups Projects

GraphQL API to delete instance Amazon S3 configurations

1 unresolved thread

What does this MR do and why?

GraphQL API for deleting instance Amazon S3 configurations

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Visit GraphiQL explorer https://gdk.test:3000/-/graphql-explorer
  2. Run the following mutation to create a new AuditEvents::Instance::AmazonS3Configuration and also note down the id.
mutation createInstanceAmazonS3Configuration {
  auditEventsInstanceAmazonS3ConfigurationCreate(input: {name: "AWS S3 Sanbox Instance", awsRegion: "us-east-1", accessKeyXid: "AKIA1234AKIA1234", secretAccessKey: "SECRET123SECRET123", bucketName: "gitlab-audit-logs"}) {
    errors,
    instanceAmazonS3Configuration{
      id,
      name,
      bucketName,
      accessKeyXid,
      awsRegion
    }
  }
  1. Run AuditEvents::Instance::AmazonS3Configuration.last in rails console and verify that a new instance Amazon S3 configuration is created.
  2. Run the following graphQL query to delete the above record
mutation deleteInstanceAmazonS3Configuration {
  auditEventsInstanceAmazonS3ConfigurationDelete(input: {id: "gid://gitlab/AuditEvents::Instance::AmazonS3Configuration/7"}) {
    errors
  }
}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #423235 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor
    1 Warning
    :warning: 0666d9b9: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
    1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend @eduardobonet profile link current availability (UTC+1, 4.5 hours behind author) @stanhu profile link current availability (UTC-8, 13.5 hours behind author)
    groupcompliance Reviewer review is optional for groupcompliance @jmontal profile link current availability (UTC-7, 12.5 hours behind author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Huzaifa Iftikhar requested review from @theoretick

    requested review from @theoretick

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 0666d9b9

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
    | Data Stores      | 23     | 0      | 0       | 0     | 23    | ✅     |
    | Create           | 54     | 0      | 7       | 0     | 61    | ✅     |
    | Govern           | 57     | 0      | 0       | 0     | 57    | ✅     |
    | Verify           | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Monitor          | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 228    | 0      | 10      | 0     | 238   | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :exclamation: test report for 0666d9b9

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Govern           | 292    | 0      | 23      | 3     | 315   | ❗     |
    | Create           | 141    | 0      | 14      | 0     | 155   | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 443    | 0      | 39      | 3     | 482   | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • added 1 commit

    • 3313c1d8 - Add GraphQL API to delete instance Amazon S3 configurations

    Compare with previous version

  • Huzaifa Iftikhar requested review from @eread

    requested review from @eread

  • Lucas Charles approved this merge request

    approved this merge request

    • Resolved by euko

      :wave: @theoretick, thanks for approving this merge request.

      This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

      Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

  • Lucas Charles requested review from @brodock and removed review request for @eread

    requested review from @brodock and removed review request for @eread

  • Lucas Charles requested review from @eread and removed review request for @theoretick

    requested review from @eread and removed review request for @theoretick

  • Evan Read
  • Evan Read
  • Evan Read removed review request for @eread

    removed review request for @eread

  • added 1 commit

    Compare with previous version

  • Huzaifa Iftikhar requested review from @eread

    requested review from @eread

  • Evan Read approved this merge request

    approved this merge request

  • Evan Read removed review request for @eread

    removed review request for @eread

  • Huzaifa Iftikhar requested review from @euko

    requested review from @euko

  • euko approved this merge request

    approved this merge request

  • euko removed review request for @euko

    removed review request for @euko

  • requested review from @harsimarsandhu

  • Huzaifa Iftikhar removed review request for @brodock

    removed review request for @brodock

  • Huzaifa Iftikhar added 1309 commits

    added 1309 commits

    Compare with previous version

  • Huzaifa Iftikhar requested review from @euko

    requested review from @euko

  • euko approved this merge request

    approved this merge request

  • euko removed review request for @euko

    removed review request for @euko

  • Harsimar Sandhu approved this merge request

    approved this merge request

  • Harsimar Sandhu resolved all threads

    resolved all threads

  • Hello @huzaifaiftikhar1 :wave:

    The database team is looking for ways to improve the database review process and we would love your help!

    If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

    @gitlab-org/database-team

    And someone will be by shortly!

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Harsimar Sandhu mentioned in commit ec6b0cec

    mentioned in commit ec6b0cec

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading