Remove column ignores after bigint conversion for notes
What does this MR do and why?
With !134217 (merged) shipped in 16.6, we can now remove the column ignore rules for the following columns:
- notes.id
- todos.note_id
- system_note_metadata.note_id
- epic_user_mentions.note_id
- suggestions.note_id
- issue_user_mentions.note_id
- note_diff_files.diff_note_id
- snippet_user_mentions.note_id
- design_user_mentions.note_id
- vulnerability_user_mentions.note_id
- commit_user_mentions.note_id
- merge_request_user_mentions.note_id
- timelogs.note_id
- award_emoji.awardable_id
- events.target_id
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #433208 (closed)
Merge request reports
Activity
changed milestone to %16.7
added Category:Database backend database database-testing-automation databaseactive devopsdata stores groupdatabase maintenancescalability pipeline:mr-approved pipeline:skip-undercoverage priority1 releasedpublished sectioncore platform severity3 typemaintenance workflowpost-deploy-db-staging labels
assigned to @krasio
removed releasedpublished label
removed workflowpost-deploy-db-staging label
removed database-testing-automation label
removed pipeline:mr-approved label
removed pipeline:skip-undercoverage label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.2 Messages CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the
danger-review
job.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @akotte
(UTC+5.5, 7.5 hours behind author)
@a_akgun
(UTC+3, 10 hours behind author)
database @terrichu
(UTC-5, 18 hours behind author)
@euko
(UTC+9, 4 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by Prabakaran Murugesan
@pedropombeiro can you please do backend maintainer review?
requested review from @pedropombeiro
- Resolved by Prabakaran Murugesan
@praba.m7n can you please do database maintainer review?
requested review from @praba.m7n
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 7aa60a44expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 48 | 0 | 9 | 0 | 57 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 222 | 0 | 12 | 0 | 234 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost User- Resolved by Prabakaran Murugesan
@pedropombeiro
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
added databaseapproved label and removed databaseactive label
removed review request for @praba.m7n