Fix cluster reindexing service preflight check
What does this MR do and why?
This MR fixes #431358 (closed), specifically, Elastic::ClusterReindexingService
.
Instead of always calculating storage requirements for all indices, we're going to do that only for selected targets
.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added bugfunctional devopsdata stores groupglobal search sectioncore platform typebug + 1 deleted label
requested review from @sdungarwal
assigned to @dgruzd
changed milestone to %16.7
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @eduardobonet
(UTC+1, same timezone as author)
@cablett
(UTC+13, 12 hours ahead of author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by Madelein van Niekerk
@sdungarwal Could I ask you to act as an initial reviewer here and assign it to
@maddievn
if everything's ok? Thank you!
added 407 commits
-
8852f53f...79fb5ee7 - 406 commits from branch
master
- d0e76ca1 - Fix cluster reindexing preflight check
-
8852f53f...79fb5ee7 - 406 commits from branch
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for be61bd22expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 48 | 0 | 9 | 0 | 57 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 222 | 0 | 12 | 0 | 234 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost User- Resolved by Madelein van Niekerk
@sdungarwal
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
requested review from @maddievn and removed review request for @sdungarwal
mentioned in merge request !138060 (merged)
added 485 commits
-
d0e76ca1...a3d87a08 - 484 commits from branch
master
- be61bd22 - Fix cluster reindexing preflight check
-
d0e76ca1...a3d87a08 - 484 commits from branch
enabled an automatic merge when the pipeline for 25f7cdba succeeds
mentioned in commit 532a65fa