Prevent modification of MR-level approval rules after MR is merged

added devopscreate groupcode review merge requests reproduced on GitLab.com sectiondev typebug labels

assigned to @marc_shaw

added 1 commit

902266dd - wip

Compare with previous version

added backend label

2 Messages

CHANGELOG missing:

If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

This merge request adds or changes files that require a review from the Database team.

This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
Prepare your MR for database review according to the docs.
Assign and mention the database reviewer suggested by Reviewer Roulette.

If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the danger-review job.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
analytics instrumentation	No engineer is available for automated assignment, please reach out to the `#g_analyze_analytics_instrumentation` Slack channel or mention `@gitlab-org/analytics-section/analytics-instrumentation/engineers` for assistance.	Maintainer review is optional for analytics instrumentation
backend	`@akotte` (UTC+5.5, 4.5 hours ahead of author)	`@jessieay` (UTC+9, 8 hours ahead of author)

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 991dbb1d

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Plan        | 55     | 0      | 0       | 0     | 55    | ✅     |
| Verify      | 31     | 0      | 0       | 0     | 31    | ✅     |
| Data Stores | 23     | 0      | 0       | 0     | 23    | ✅     |
| Govern      | 72     | 0      | 0       | 0     | 72    | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Create      | 54     | 0      | 7       | 0     | 61    | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
| Package     | 15     | 0      | 1       | 0     | 16    | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 264    | 0      | 9       | 0     | 273   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 991dbb1d

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 550    | 0      | 52      | 8     | 602   | ✅     |
| Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
| Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
| Plan        | 8      | 0      | 0       | 0     | 8     | ✅     |
| Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 576    | 0      | 54      | 8     | 630   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+