Resolve "Add a cop to ensure a correct merge request link"
What does this MR do and why?
In this merge request, we are adding a new cop to validate the introduced_by_url
url (batched background migrations dictionary).
We need to have this link in the proper format because we will have a job that will extract the merge request ID from the link. More info here: gitlab-org/database-team/gitlab-com-database-testing!172 (comment 1658600386)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #432943 (closed)
Merge request reports
Activity
changed milestone to %16.7
added database devopsdata stores groupdatabase sectioncore platform labels
assigned to @dfrazao-gitlab
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@dfrazao-gitlab - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added docs-only label
cc @praba.m7n
- A deleted user
added backend databasereview pending labels
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
db/docs/batched_background_migrations/backfill_finding_id_in_vulnerabilities.yml
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @ibaum
(UTC-6, 7 hours behind author)
@alexpooley
(UTC+8, 7 hours ahead of author)
database @morefice
(UTC+1, same timezone as author)
@ahegyi
(UTC+1, same timezone as author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User-
removed docs-only label
Setting label(s) Category:Database based on groupdatabase.
added Category:Database label
added 53 commits
-
a587990b...6ad18e7c - 52 commits from branch
master
- 319a7361 - Add new rubocop rule
-
a587990b...6ad18e7c - 52 commits from branch