Update merge request approval documentation
Compare changes
@@ -114,16 +114,23 @@ more of these:
@@ -183,21 +190,24 @@ for protected branches.
Some confusion exists with if a user with the Reporter
role is able to approver merge requests or not.
This seems to stem from the statement under the section Eligible Approvers stating the below:
The following users can approve merge requests if they have Developer or higher permissions:
- Users added as approvers at the project or merge request level.
- Users who are Code owners of the files changed in the merge request.
Then under the section called Merge request approval segregation of duties it states:
You may have to grant users with the Reporter role permission to approve merge requests before they can merge to a protected branch.
This MR hopes to tie those two sections together and clear up some of the confusion.
ZD Ticket: https://gitlab.zendesk.com/agent/tickets/470324
If you are a GitLab team member and only adding documentation, do not add any of the following labels:
~"frontend"
~"backend"
~"type::bug"
~"database"
These labels cause the MR to be added to code verification QA issues.
Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.
If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.
Default behavior
, say something like Default behavior when you close an issue
.Configuring GDK
, say something like Configure GDK
.