Skip to content
Snippets Groups Projects

Enable group level vulnerability report grouping

Merged Savas Vedova requested to merge 431633-add-grouping-to-group-report into master
1 unresolved thread

What does this MR do and why?

Enable group level vulnerability report grouping

Introduce the feature behind the :group_level_vulnerability_report_grouping feature flag.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

  1. Enable :group_level_vulnerability_report_grouping feature flag
  • echo "Feature.enable(:group_level_vulnerability_report_grouping)" | rails c
  1. Create a group with vulnerabilities
  1. Visit Group > Secure > Vulnerability Report
  2. Test the Group By feature

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #431633 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor
    1 Warning
    :warning: 8903adf7: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
    1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend @imand3r profile link current availability (UTC-8, 9 hours behind author) @rzwambag profile link current availability (UTC+1, same timezone as author)
    frontend @mcavoj profile link current availability (UTC+1, same timezone as author) @ekigbo profile link current availability (UTC+11, 10 hours ahead of author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • requested review from @lorenzvanherwaarden

  • Savas Vedova
  • Savas Vedova
  • Savas Vedova
  • Savas Vedova added 1 commit

    added 1 commit

    • 94fceda4 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • mentioned in issue #431633 (closed)

  • Author Maintainer

    @beckalippert can you please review this MR?

  • Savas Vedova requested review from @beckalippert

    requested review from @beckalippert

  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 1b70913d and a69b52bc

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.1 MB 4.1 MB - 0.0 %
    mainChunk 3.04 MB 3.04 MB - 0.0 %

    Note: We do not have exact data for 1b70913d. So we have used data from: 23f9137d.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for a69b52bc

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Data Stores      | 23     | 0      | 0       | 0     | 23    | ✅     |
    | Verify           | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Create           | 48     | 0      | 9       | 0     | 57    | ✅     |
    | Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Govern           | 57     | 0      | 0       | 0     | 57    | ✅     |
    | Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Monitor          | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 222    | 0      | 12      | 0     | 234   | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :exclamation: test report for a69b52bc

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Govern | 176    | 0      | 14      | 2     | 190   | ❗     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 176    | 0      | 14      | 2     | 190   | ❗     |
    +--------+--------+--------+---------+-------+-------+--------+

    e2e-review-qa: :x: test report for ce780034

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Govern           | 47     | 4      | 2       | 0     | 53    | ❌     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
    | Create           | 6      | 2      | 2       | 2     | 10    | ❌     |
    | Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | ModelOps         | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 62     | 6      | 8       | 2     | 76    | ❌     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Savas Vedova mentioned in issue #432842

    mentioned in issue #432842

  • Lorenz van Herwaarden approved this merge request

    approved this merge request

    • Resolved by David Pisek

      :wave: @lorenzvanherwaarden, thanks for approving this merge request.

      This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

      Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

  • Savas Vedova added 1 commit

    added 1 commit

    Compare with previous version

  • Savas Vedova requested review from @ghavenga

    requested review from @ghavenga

  • Savas Vedova requested review from @dpisek

    requested review from @dpisek

  • Savas Vedova added 501 commits

    added 501 commits

    Compare with previous version

  • Gregory Havenga approved this merge request

    approved this merge request

  • Becka Lippert approved this merge request

    approved this merge request

  • removed review request for @lorenzvanherwaarden

  • David Pisek approved this merge request

    approved this merge request

  • David Pisek
  • David Pisek resolved all threads

    resolved all threads

  • David Pisek enabled an automatic merge when the pipeline for 0930f84d succeeds

    enabled an automatic merge when the pipeline for 0930f84d succeeds

  • Savas Vedova resolved all threads

    resolved all threads

  • mentioned in issue #433099 (closed)

  • Savas Vedova aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Savas Vedova added 172 commits

    added 172 commits

    Compare with previous version

  • Savas Vedova mentioned in issue #422510

    mentioned in issue #422510

  • David Pisek enabled an automatic merge when the pipeline for 9ec2259e succeeds

    enabled an automatic merge when the pipeline for 9ec2259e succeeds

  • Savas Vedova aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Savas Vedova added 255 commits

    added 255 commits

    Compare with previous version

  • David Pisek enabled an automatic merge when the pipeline for eced25ec succeeds

    enabled an automatic merge when the pipeline for eced25ec succeeds

  • Savas Vedova mentioned in epic &10164

    mentioned in epic &10164

  • Savas Vedova aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Savas Vedova added 47 commits

    added 47 commits

    Compare with previous version

  • David Pisek enabled an automatic merge when the pipeline for de48a45e succeeds

    enabled an automatic merge when the pipeline for de48a45e succeeds

  • Savas Vedova resolved all threads

    resolved all threads

  • Savas Vedova aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Savas Vedova added 328 commits

    added 328 commits

    Compare with previous version

  • David Pisek enabled an automatic merge when the pipeline for 8a1bc663 succeeds

    enabled an automatic merge when the pipeline for 8a1bc663 succeeds

  • merged

  • David Pisek mentioned in commit c7086021

    mentioned in commit c7086021

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading