Removing Quarantine status for Account recovery flaky test
What does this MR do and why?
We are removing quarantine from this test which does not look like flaky anymore.
As per discussion here, we will de-quarantine this test and observe for some time
Update -
Looks like flaky error was reproduced here - https://gitlab.com/gitlab-org/gitlab/-/jobs/5699163861.
I made some optimisations in the spec as suggested here - https://www.cloudbees.com/blog/faster-rails-tests and trying again.
After making test optimisations where we are waiting for the request to finish and using suggested finders from the [above link](https://www.cloudbees.com/blog/faster-rails-tests) .. looks like the test is not flaky anymore .. This MR is up for review again
Update as on 18 Dec 2023-
After capybara, finder optimisations and adding wait_for_request , test seems to be stable after multiple pipeline runs and hence ready for merging
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.