Skip to content
Snippets Groups Projects

Revert "Merge branch 'sc1-upgrade-sidekiq-gem-only' into 'master'"

Merged Mayra Cabrera requested to merge revert-c57ec169 into master

Purpose of revert

Revert !135185 (merged) to unblock gitlab-com/gl-infra/production#17158 (closed)

Checklist

Milestone info

  • I am reverting something in the current milestone. No changelog is needed, and I've added a ~"regression:*" label.
  • I am reverting something in a different milestone. A changelog is needed, and I've removed the ~"regression:*" label.

Related issues and merge requests

Edited by Mayra Cabrera

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Contributor
    3 Warnings
    :warning: This merge request is quite big (797 lines changed), please consider splitting it into multiple merge requests.
    :warning: This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time.
    :warning: This merge request does not refer to an existing milestone.
    1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend @ddieulivol profile link current availability (UTC+1, 7 hours ahead of author) @proglottis profile link current availability (UTC+13, 19 hours ahead of author)
    test for spec/features/* @ddieulivol profile link current availability (UTC+1, 7 hours ahead of author) Maintainer review is optional for test for spec/features/*

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    Rubygems

    This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • added typebug label

  • Mayra Cabrera marked this merge request as ready

    marked this merge request as ready

  • Simon Tomlinson requested review from @stomlinson

    requested review from @stomlinson

  • Mayra Cabrera resolved all threads

    resolved all threads

  • Simon Tomlinson approved this merge request

    approved this merge request

  • Simon Tomlinson mentioned in commit 8cf82c93

    mentioned in commit 8cf82c93

  • Successfully picked into 16-7-auto-deploy-2023112020.

    This merge request will receive additional notifications as it's deployed. You can also use the following chatops command to check its status: /chatops run auto_deploy status https://gitlab.com/gitlab-org/gitlab/-/merge_requests/137444

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading