Migrate QA Access Token page object attributes to data-testid

added QA Quality maintenancerefactor typemaintenance labels

	3 Warnings
⚠	a504314b: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
⚠	This merge request contains lines with testid selectors. Please ensure `e2e:package-and-test` job is run.
⚠	This merge request contains deprecated data-qa-selector attribute. Please use data-testid attribute instead.

Deprecated `testid` selectors

The following changed lines in this MR contain testid selectors:

`app/helpers/ssh_keys_helper.rb`

+        testid: 'delete-ssh-key-button',
+            'data-testid': 'ssh-key-delete-modal',

`app/views/profiles/keys/_form.html.haml`

+      = f.text_area :key, class: "form-control gl-form-input js-add-ssh-key-validation-input", rows: 8, required: true, data: { supported_algorithms: Gitlab::SSHPublicKey.supported_algorithms, testid: 'key-public-key-field' }
+        = f.text_field :title, class: "form-control gl-form-input input-lg", required: true, placeholder: s_('Profiles|Example: MacBook key'), data: { testid: 'key-title-field' }
+    = f.submit s_('Profiles|Add key'), class: "js-add-ssh-key-validation-original-submit", pajamas_button: true, data: { testid: 'add-key-button' }

`app/views/profiles/keys/_key_table.html.haml`

+    %table.table.b-table.gl-table.b-table-stacked-md.gl-mt-n1.gl-mb-n2.ssh-keys-list{ data: { testid: 'ssh-keys-list' } }

If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure the tests in follow-up-e2e:package-and-test-ee pipeline are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Deprecated `data-qa-selector` selectors

The following lines in this MR contain deprecated data-qa-selector selectors:

`app/helpers/ssh_keys_helper.rb`

-        qa_selector: 'delete_ssh_key_button',
-            'data-qa-selector': 'ssh_key_delete_modal',

`app/views/profiles/keys/_form.html.haml`

-      = f.text_area :key, class: "form-control gl-form-input js-add-ssh-key-validation-input", rows: 8, required: true, data: { supported_algorithms: Gitlab::SSHPublicKey.supported_algorithms, qa_selector: 'key_public_key_field' }
-        = f.text_field :title, class: "form-control gl-form-input input-lg", required: true, placeholder: s_('Profiles|Example: MacBook key'), data: { qa_selector: 'key_title_field' }
-    = f.submit s_('Profiles|Add key'), class: "js-add-ssh-key-validation-original-submit", pajamas_button: true, data: { qa_selector: 'add_key_button' }

`app/views/profiles/keys/_key_table.html.haml`

-    %table.table.b-table.gl-table.b-table-stacked-md.gl-mt-n1.gl-mb-n2.ssh-keys-list{ data: { qa_selector: 'ssh_keys_list' } }

Please ensure all deprecated data-qa-selector attributes are replaced with data-testid attributes in accordance with our Testing Guide.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	`@arpitgogia` (UTC+5.5, 5.5 hours ahead of author)	`@alexpooley` (UTC+8, 8 hours ahead of author)
frontend	`@lorenzvanherwaarden` (UTC+1, 1 hour ahead of author)	`@rchanila` (UTC+11, 11 hours ahead of author)
QA	`@john.mcdonnell` (UTC+0, same timezone as author)	`@ddavison` (UTC-5, 5 hours behind author)

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the 🔁 danger-review job that generated this comment.

Generated by 🚫 Danger

changed title from Accesstoken testid to Migrate QA Access Token page object attributes to data-testid

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits aeff9e64 and 8ed02218

✨ Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.06 MB	4.06 MB	-	-0.0 %
mainChunk	3.05 MB	3.05 MB	-	0.0 %

Please look at the full report for more details

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: ✅ test report for a504314b

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 50     | 0      | 7       | 0     | 57    | ✅     |
| Verify           | 31     | 0      | 0       | 0     | 31    | ✅     |
| Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
| Govern           | 57     | 0      | 0       | 0     | 57    | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Data Stores      | 23     | 0      | 0       | 0     | 23    | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
| Monitor          | 8      | 0      | 0       | 0     | 8     | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 224    | 0      | 10      | 0     | 234   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: ❌ test report for a504314b

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Verify           | 138    | 0      | 27      | 0     | 165   | ✅     |
| Plan             | 249    | 0      | 10      | 0     | 259   | ✅     |
| Govern           | 295    | 3      | 20      | 6     | 318   | ❌     |
| Create           | 543    | 0      | 67      | 0     | 610   | ✅     |
| Manage           | 40     | 1      | 9       | 15    | 50    | ❌     |
| Release          | 15     | 0      | 3       | 0     | 18    | ✅     |
| Package          | 226    | 0      | 17      | 0     | 243   | ✅     |
| Data Stores      | 119    | 0      | 1       | 1     | 120   | ❗     |
| Systems          | 8      | 0      | 0       | 0     | 8     | ✅     |
| GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
| Analytics        | 7      | 0      | 0       | 0     | 7     | ✅     |
| Fulfillment      | 8      | 0      | 69      | 0     | 77    | ✅     |
| Monitor          | 39     | 0      | 7       | 0     | 46    | ✅     |
| Configure        | 1      | 0      | 9       | 0     | 10    | ✅     |
| Growth           | 0      | 0      | 6       | 0     | 6     | ➖     |
| ModelOps         | 0      | 0      | 6       | 0     | 6     | ➖     |
| Secure           | 6      | 0      | 3       | 0     | 9     | ✅     |
| Framework sanity | 0      | 0      | 5       | 0     | 5     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 1696   | 4      | 260     | 22    | 1960  | ❌     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-review-qa: ✅ test report for a504314b

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 8      | 0      | 2       | 0     | 10    | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Govern           | 3      | 0      | 0       | 0     | 3     | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
| Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 20     | 0      | 5       | 0     | 25    | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

added 1 commit

34ef02fc - Migrate QA SSH keys to testid

Compare with previous version

changed the description

mentioned in issue gitlab-org/quality/quality-engineering/team-tasks#1825 (closed)

added 1107 commits

34ef02fc...b4fd9d43 - 1103 commits from branch master
2cfa8c6e - Migrate QA access tokens to testid
4a437c00 - Migrate QA SSH keys to testid
75518936 - Update access token app spec
8ed02218 - Update frontend specs

Compare with previous version

mentioned in issue #408726 (closed)

Hi @marcogreg could you review this MR for Backend? It relates to gitlab-org/quality/quality-engineering/team-tasks#1822 (closed) - migrating data-qa-selector test attributes to data-testid. Thanks!

requested review from @marcogreg

Hi @rcrespo3 could you review this MR for Frontend? It relates to gitlab-org/quality/quality-engineering/team-tasks#1822 (closed) - migrating data-qa-selector test attributes to data-testid. Thanks!

requested review from @rcrespo3

Hi @richard.chong could you review this testid migration MR? Thanks

requested review from @richard.chong

approved this merge request

requested review from @zcuddy and removed review request for @rcrespo3

👋 @rcrespo3, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.