Skip to content

Migrate Runner and Visibility Permissions QA page objects to use testid

Will Meek requested to merge runner_visibility_testids into master

What does this MR do and why?

Migrate Runner and Visibility Features Permissions QA page objects to use data-testid attributes rather than data-qa-selector as per gitlab-org/quality/quality-engineering/team-tasks#1822 (closed)

Removes unused selectors from Runner page object.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Run affected E2E specs eg.

CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://gdk.test:3000/ ./qa/specs/features/browser_ui/4_verify/runner/register_runner_spec.rb

CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://gdk.test:3000/ ./qa/specs/features/ee/browser_ui/10_govern/project/project_audit_logs_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports