Skip to content
Snippets Groups Projects

Project overview page reoganisation: add sidebar

Merged Sascha Eggenberger requested to merge project-overview-layout-reorganisation into master

What does this MR do and why?

Project overview page re-oganisation Part I: Add new sidebar. This MR is part of Project overview page updates (#429186 - closed) in a series of changes related to each other.

Note: This MR moves content into the new right sidebar. It does not alter or remove any content. All changes are behind a new FF project_overview_reorg

Changes:

  • Adds new right sidebar
  • Adds new project settings button to sidebar
  • Moves project description to sidebar
  • Moves languages bar to sidebar
  • Moves project stats to sidebar
  • Moves project buttons to sidebar

Note that this is the first Part and we will iterate on it with upcoming MRs. Also for that reason it does not yet add test coverage for the new layout.

Screenshots or screen recordings

Before After
before after

Empty project

Before After
empty_before empty_after

How to set up and validate locally

  1. Enable FF echo "Feature.enable(:project_overview_reorg)" | rails c
  2. Check out a project overview page, e.g. http://gdk.test:3000/gitlab-org/gitlab-shell
  3. Check out an empty project page (or create one)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to Create sidebar to display project overview meta... (#431537 - closed), Project overview page updates (#429186 - closed), ✂️ UX Paper Cuts 16.7 → Project page (#430244 - closed)

Edited by Sascha Eggenberger

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Elwyn Benson
  • Elwyn Benson
  • Elwyn Benson
  • Elwyn Benson approved this merge request

    approved this merge request

  • Elwyn Benson removed review request for @elwyn-gitlab

    removed review request for @elwyn-gitlab

  • Sascha Eggenberger changed the description

    changed the description

  • added 1 commit

    • fb937934 - Add some button alignment fixes to the sidebar

    Compare with previous version

  • mentioned in issue #430244 (closed)

  • added 1 commit

    • 88452014 - Add some button alignment fixes to the sidebar

    Compare with previous version

  • added 1 commit

    • 11562265 - Add some button alignment fixes to the sidebar

    Compare with previous version

  • added 1 commit

    • 306d409b - Add some button alignment fixes to the sidebar

    Compare with previous version

  • Contributor

    🛠 Generated by gitlab_quality-test_tooling.

    Please share your feedback and suggestions.


    🐌 Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #5597251591 spec/features/snippets/show_spec.rb#L33 Snippet when signed in as the snippet owner behaves like a "Your work" page with sidebar and breadcrumbs shows the "Your work" sidebar 61.99 s < 50.13 s
    #5597251591 spec/features/snippets/show_spec.rb#L33 Snippet when signed in as the snippet owner behaves like a "Your work" page with sidebar and breadcrumbs shows the correct sidebar menu item as active 61.76 s < 50.13 s
    #5597251591 spec/features/snippets/show_spec.rb#L33 Snippet when signed in as the snippet owner behaves like a "Your work" page with sidebar and breadcrumbs breadcrumbs has "Your work" as its root breadcrumb 62.07 s < 50.13 s
    #5597251591 spec/features/snippets/show_spec.rb#L41 Snippet when signed in as external user behaves like a "Your work" page with sidebar and breadcrumbs shows the "Your work" sidebar 62.17 s < 50.13 s
    #5597251591 spec/features/snippets/show_spec.rb#L41 Snippet when signed in as external user behaves like a "Your work" page with sidebar and breadcrumbs shows the correct sidebar menu item as active 62.18 s < 50.13 s
  • A deleted user added rspec:slow test detected label
  • added 1 commit

    • 14c76d7e - Add some button alignment fixes to the sidebar

    Compare with previous version

  • Sascha Eggenberger added 1299 commits

    added 1299 commits

    • 14c76d7e...5146c519 - 1296 commits from branch master
    • a190aaca - Project overview page reoganisation: add sidebar
    • 14b829f8 - Update stat links in project sidebar
    • 29dc71a1 - Add some button alignment fixes to the sidebar

    Compare with previous version

  • Sascha Eggenberger removed review request for @hmehra

    removed review request for @hmehra

  • Sascha Eggenberger requested review from @psimyn

    requested review from @psimyn

  • Hey @vitallium can you do the maintainer review on this one? TY!

    Edited by Sascha Eggenberger
  • Sascha Eggenberger added 291 commits

    added 291 commits

    • 29dc71a1...e353da49 - 288 commits from branch master
    • 3cbd3ef9 - Project overview page reoganisation: add sidebar
    • fc89c621 - Update stat links in project sidebar
    • 97b36034 - Add some button alignment fixes to the sidebar

    Compare with previous version

  • Sascha Eggenberger requested review from @vitallium and removed review request for @psimyn

    requested review from @vitallium and removed review request for @psimyn

  • Sascha Eggenberger added 302 commits

    added 302 commits

    • 97b36034...a650f9d4 - 299 commits from branch master
    • b87567d5 - Project overview page reoganisation: add sidebar
    • 08be8e2c - Update stat links in project sidebar
    • ec104dc9 - Add some button alignment fixes to the sidebar

    Compare with previous version

  • Sascha Eggenberger added 65 commits

    added 65 commits

    • ec104dc9...da675609 - 62 commits from branch master
    • fa5bab26 - Project overview page reoganisation: add sidebar
    • c6fdc99f - Update stat links in project sidebar
    • 57c884dd - Add some button alignment fixes to the sidebar

    Compare with previous version

  • Vitaly Slobodin approved this merge request

    approved this merge request

  • Vitaly Slobodin resolved all threads

    resolved all threads

  • Vitaly Slobodin mentioned in commit 90bd1213

    mentioned in commit 90bd1213

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading