Project overview page reoganisation: add sidebar
What does this MR do and why?
Project overview page re-oganisation Part I: Add new sidebar. This MR is part of Project overview page updates (#429186 - closed) in a series of changes related to each other.
Note: This MR moves content into the new right sidebar. It does not alter or remove any content. All changes are behind a new FF project_overview_reorg
Changes:
- Adds new right sidebar
- Adds new project settings button to sidebar
- Moves project description to sidebar
- Moves languages bar to sidebar
- Moves project stats to sidebar
- Moves project buttons to sidebar
Note that this is the first Part and we will iterate on it with upcoming MRs. Also for that reason it does not yet add test coverage for the new layout.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
Empty project
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Enable FF
echo "Feature.enable(:project_overview_reorg)" | rails c
- Check out a project overview page, e.g. http://gdk.test:3000/gitlab-org/gitlab-shell
- Check out an empty project page (or create one)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to Create sidebar to display project overview meta... (#431537 - closed), Project overview page updates (#429186 - closed), ✂️ UX Paper Cuts 16.7 → Project page (#430244 - closed)
Merge request reports
Activity
changed milestone to %16.7
added UX UX Paper Cuts frontend groupux paper cuts maintenanceusability sectiondev severity4 typemaintenance + 1 deleted label
assigned to @seggenberger
- A deleted user
added backend label
4 Warnings ⚠ This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.⚠ This merge request is quite big (580 lines changed), please consider splitting it into multiple merge requests. ⚠ 57c884dd: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ⚠ This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.Deprecated
testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/views/projects/_sidebar.html.haml
+ .project-badges.gl-mb-2{ data: { testid: 'project-badges-content' } } + data: { testid: 'badge-image-link', qa_link_url: badge_link_url } }> + .project-buttons.gl-mb-2.js-show-on-project-root{ data: { testid: 'project-buttons' } }
app/views/projects/_invite_members_empty_project.html.haml
-%h4.gl-mt-0.gl-mb-3{ data: { testid: 'invite-member-section', + %p.gl-font-weight-bold.gl-text-gray-900.gl-mt-0.gl-mt-n1.gl-mb-3{ data: { testid: 'invite-member-section', + %h4.gl-mt-0.gl-mb-3{ data: { testid: 'invite-member-section',
app/views/projects/empty.html.haml
+ .project-buttons.gl-mb-5{ data: { testid: 'quick-actions-container' } } -.project-buttons{ data: { testid: 'quick-actions-container' } } + .project-buttons{ data: { testid: 'quick-actions-container' } }
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start thetrigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure the tests infollow-up-e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @ibaum
(UTC-6, 7 hours behind author)
@dstull
(UTC-5, 6 hours behind author)
frontend @lorenzvanherwaarden
(UTC+1, same timezone as author)
@ealcantara
(UTC+1, same timezone as author)
QA @hmuralidhar
(UTC+11, 10 hours ahead of author)
Maintainer review is optional for QA test for spec/features/*
@ibaum
(UTC-6, 7 hours behind author)
Maintainer review is optional for test for spec/features/*
UX @ipelaez1
(UTC-5, 6 hours behind author)
Maintainer review is optional for UX Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f0b79a75 and 57c884dd
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.06 MB 4.06 MB - 0.0 % mainChunk 3.05 MB 3.05 MB - 0.0 %
Note: We do not have exact data for f0b79a75. So we have used data from: 143249ee.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
✅ test report for 57c884ddexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Create | 48 | 0 | 9 | 0 | 57 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 222 | 0 | 12 | 0 | 234 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
❌ test report for 57c884ddexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 183 | 1 | 36 | 0 | 220 | ❌ | | Package | 259 | 1 | 19 | 0 | 279 | ❌ | | Govern | 375 | 1 | 29 | 4 | 405 | ❌ | | Release | 20 | 0 | 4 | 0 | 24 | ✅ | | Plan | 320 | 0 | 13 | 0 | 333 | ✅ | | Data Stores | 149 | 0 | 1 | 1 | 150 | ❗ | | Create | 646 | 11 | 80 | 0 | 737 | ❌ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 43 | 1 | 11 | 16 | 55 | ❌ | | Analytics | 9 | 0 | 0 | 0 | 9 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Fulfillment | 10 | 0 | 92 | 0 | 102 | ✅ | | Monitor | 40 | 0 | 9 | 0 | 49 | ✅ | | Configure | 1 | 0 | 12 | 0 | 13 | ✅ | | Growth | 0 | 0 | 8 | 0 | 8 | ➖ | | Secure | 8 | 0 | 4 | 0 | 12 | ✅ | | Framework sanity | 0 | 0 | 4 | 0 | 4 | ➖ | | ModelOps | 0 | 0 | 8 | 0 | 8 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2073 | 15 | 331 | 21 | 2419 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
✅ test report for 57c884ddexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Create | 6 | 0 | 4 | 0 | 10 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 18 | 0 | 7 | 0 | 25 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 2d0f819c - Project overview page reoganisation: add sidebar
- A deleted user
added QA label
removed QA label
added 1 commit
- b48cb26a - Project overview page reoganisation: add sidebar
- A deleted user
added QA label
added 1 commit
- b2a39972 - Project overview page reoganisation: add sidebar
- A deleted user
added feature flag label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@cd30ef0a
added 1 commit
- 91da339c - Project overview page reoganisation: add sidebar
- Resolved by Sascha Eggenberger
cc @mle as discussed this is the first MR which adds the new sidebar region and moves existing things around.
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@ae3c2cb5
added 1 commit
- 60347c6e - Project overview page reoganisation: add sidebar
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@42de4a6c
requested review from @annabeldunstone
- Resolved by Sascha Eggenberger
removed review request for @annabeldunstone
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@af222aa1
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@b4492164
- Resolved by Sascha Eggenberger
@jmiocene would you mind reviewing this as @annabeldunstone pushed some changes, too? TY
added 1 commit
- 7ad8c7ed - Add some button alignment fixes to the sidebar
requested review from @jmiocene
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@874a3d16
removed review request for @jmiocene
- Resolved by Vitaly Slobodin
👋 @jmiocene
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@797d448e
- Resolved by Sascha Eggenberger
requested review from @hmehra and @elwyn-gitlab
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
removed review request for @elwyn-gitlab
added 1 commit
- fb937934 - Add some button alignment fixes to the sidebar
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@0a3a9250
mentioned in issue #430244 (closed)
added 1 commit
- 88452014 - Add some button alignment fixes to the sidebar
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@38aa703b
added 1 commit
- 11562265 - Add some button alignment fixes to the sidebar
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@290e9a61
added 1 commit
- 306d409b - Add some button alignment fixes to the sidebar
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@bc34b5b9
mentioned in issue gitlab-com/www-gitlab-com#31164 (closed)
🛠 Generated bygitlab_quality-test_tooling
.♻ Please share your feedback and suggestions.
🐌 Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #5597251591 spec/features/snippets/show_spec.rb#L33
Snippet when signed in as the snippet owner behaves like a "Your work" page with sidebar and breadcrumbs shows the "Your work" sidebar 61.99 s < 50.13 s #5597251591 spec/features/snippets/show_spec.rb#L33
Snippet when signed in as the snippet owner behaves like a "Your work" page with sidebar and breadcrumbs shows the correct sidebar menu item as active 61.76 s < 50.13 s #5597251591 spec/features/snippets/show_spec.rb#L33
Snippet when signed in as the snippet owner behaves like a "Your work" page with sidebar and breadcrumbs breadcrumbs has "Your work" as its root breadcrumb 62.07 s < 50.13 s #5597251591 spec/features/snippets/show_spec.rb#L41
Snippet when signed in as external user behaves like a "Your work" page with sidebar and breadcrumbs shows the "Your work" sidebar 62.17 s < 50.13 s #5597251591 spec/features/snippets/show_spec.rb#L41
Snippet when signed in as external user behaves like a "Your work" page with sidebar and breadcrumbs shows the correct sidebar menu item as active 62.18 s < 50.13 s - A deleted user
added rspec:slow test detected label
added 1 commit
- 14c76d7e - Add some button alignment fixes to the sidebar
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@21470fb9
added 1299 commits
-
14c76d7e...5146c519 - 1296 commits from branch
master
- a190aaca - Project overview page reoganisation: add sidebar
- 14b829f8 - Update stat links in project sidebar
- 29dc71a1 - Add some button alignment fixes to the sidebar
Toggle commit list-
14c76d7e...5146c519 - 1296 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@13c179e0
removed review request for @hmehra
requested review from @psimyn
Hey @vitallium can you do the maintainer review on this one? TY!
Edited by Sascha Eggenbergeradded 291 commits
-
29dc71a1...e353da49 - 288 commits from branch
master
- 3cbd3ef9 - Project overview page reoganisation: add sidebar
- fc89c621 - Update stat links in project sidebar
- 97b36034 - Add some button alignment fixes to the sidebar
Toggle commit list-
29dc71a1...e353da49 - 288 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@1852043f
requested review from @vitallium and removed review request for @psimyn
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@7337ac9f
- Resolved by Vitaly Slobodin
JH pipeline has failed. Retried it.
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@79578093
added 302 commits
-
97b36034...a650f9d4 - 299 commits from branch
master
- b87567d5 - Project overview page reoganisation: add sidebar
- 08be8e2c - Update stat links in project sidebar
- ec104dc9 - Add some button alignment fixes to the sidebar
Toggle commit list-
97b36034...a650f9d4 - 299 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@54e4f5a5
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@b5ef88c1
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e8fb97c1
added 65 commits
-
ec104dc9...da675609 - 62 commits from branch
master
- fa5bab26 - Project overview page reoganisation: add sidebar
- c6fdc99f - Update stat links in project sidebar
- 57c884dd - Add some button alignment fixes to the sidebar
Toggle commit list-
ec104dc9...da675609 - 62 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@70ac2c8c
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@2ff27d08
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@ea6c6172
mentioned in commit 90bd1213
added workflowstaging-canary label