Project overview page reoganisation: add sidebar
What does this MR do and why?
Project overview page re-oganisation Part I: Add new sidebar. This MR is part of Project overview page updates (#429186 - closed) in a series of changes related to each other.
Note: This MR moves content into the new right sidebar. It does not alter or remove any content. All changes are behind a new FF project_overview_reorg
Changes:
- Adds new right sidebar
- Adds new project settings button to sidebar
- Moves project description to sidebar
- Moves languages bar to sidebar
- Moves project stats to sidebar
- Moves project buttons to sidebar
Note that this is the first Part and we will iterate on it with upcoming MRs. Also for that reason it does not yet add test coverage for the new layout.
Screenshots or screen recordings
| Before | After |
|---|---|
 |
 |
Empty project
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
- Enable FF
echo "Feature.enable(:project_overview_reorg)" | rails c - Check out a project overview page, e.g. http://gdk.test:3000/gitlab-org/gitlab-shell
- Check out an empty project page (or create one)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to Create sidebar to display project overview meta... (#431537 - closed), Project overview page updates (#429186 - closed), ✂️ UX Paper Cuts 16.7 → Project page (#430244 - closed)
Merge request reports
Activity
changed milestone to %16.7
added UX UX Paper Cuts frontend groupux paper cuts maintenanceusability sectiondev severity4 typemaintenance + 1 deleted label
assigned to @seggenberger
- A deleted user
added backend label
4 Warnings 
This MR changes code in ee/, but its Changelog commit is missing theEE: truetrailer. Consider adding it to your Changelog commits.This merge request is quite big (580 lines changed), please consider splitting it into multiple merge requests. 57c884dd: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request contains lines with testid selectors. Please ensure e2e:package-and-testjob is run.Deprecated
testidselectorsThe following changed lines in this MR contain
testidselectors:app/views/projects/_sidebar.html.haml+ .project-badges.gl-mb-2{ data: { testid: 'project-badges-content' } } + data: { testid: 'badge-image-link', qa_link_url: badge_link_url } }> + .project-buttons.gl-mb-2.js-show-on-project-root{ data: { testid: 'project-buttons' } }app/views/projects/_invite_members_empty_project.html.haml-%h4.gl-mt-0.gl-mb-3{ data: { testid: 'invite-member-section', + %p.gl-font-weight-bold.gl-text-gray-900.gl-mt-0.gl-mt-n1.gl-mb-3{ data: { testid: 'invite-member-section', + %h4.gl-mt-0.gl-mb-3{ data: { testid: 'invite-member-section',app/views/projects/empty.html.haml+ .project-buttons.gl-mb-5{ data: { testid: 'quick-actions-container' } } -.project-buttons{ data: { testid: 'quick-actions-container' } } + .project-buttons{ data: { testid: 'quick-actions-container' } }If the
e2e:package-and-testjob in theqastage has run automatically, please ensure the tests are passing. If the job has not run, please start thetrigger-omnibus-and-follow-up-e2ejob in theqastage and ensure the tests infollow-up-e2e:package-and-test-eepipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @ibaum
(UTC-6, 7 hours behind author)@dstull (UTC-5, 6 hours behind author)frontend @lorenzvanherwaarden (UTC+1, same timezone as author)@ealcantara (UTC+1, same timezone as author)QA @hmuralidhar (UTC+11, 10 hours ahead of author)Maintainer review is optional for QA test for spec/features/*@ibaum (UTC-6, 7 hours behind author)Maintainer review is optional for test for spec/features/*UX @ipelaez1 (UTC-5, 6 hours behind author)Maintainer review is optional for UX Please check reviewer's status!
-
Reviewer is available!
-
Reviewer is unavailable!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by Ghost User-
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f0b79a75 and 57c884dd
Entrypoint / Name Size before Size after Diff Diff in percent average 4.06 MB 4.06 MB - 0.0 % mainChunk 3.05 MB 3.05 MB - 0.0 %
Note: We do not have exact data for f0b79a75. So we have used data from: 143249ee.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Allure report
allure-report-publishergenerated test report!e2e-test-on-gdk:
expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Create | 48 | 0 | 9 | 0 | 57 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 222 | 0 | 12 | 0 | 234 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+e2e-package-and-test:
expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 183 | 1 | 36 | 0 | 220 | ❌ | | Package | 259 | 1 | 19 | 0 | 279 | ❌ | | Govern | 375 | 1 | 29 | 4 | 405 | ❌ | | Release | 20 | 0 | 4 | 0 | 24 | ✅ | | Plan | 320 | 0 | 13 | 0 | 333 | ✅ | | Data Stores | 149 | 0 | 1 | 1 | 150 | ❗ | | Create | 646 | 11 | 80 | 0 | 737 | ❌ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 43 | 1 | 11 | 16 | 55 | ❌ | | Analytics | 9 | 0 | 0 | 0 | 9 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Fulfillment | 10 | 0 | 92 | 0 | 102 | ✅ | | Monitor | 40 | 0 | 9 | 0 | 49 | ✅ | | Configure | 1 | 0 | 12 | 0 | 13 | ✅ | | Growth | 0 | 0 | 8 | 0 | 8 | ➖ | | Secure | 8 | 0 | 4 | 0 | 12 | ✅ | | Framework sanity | 0 | 0 | 4 | 0 | 4 | ➖ | | ModelOps | 0 | 0 | 8 | 0 | 8 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2073 | 15 | 331 | 21 | 2419 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+e2e-review-qa:
expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Create | 6 | 0 | 4 | 0 | 10 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 18 | 0 | 7 | 0 | 25 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+Edited by Ghost Useradded 1 commit
- 2d0f819c - Project overview page reoganisation: add sidebar
- A deleted user
added QA label
removed QA label
added 1 commit
- b48cb26a - Project overview page reoganisation: add sidebar
- A deleted user
added QA label
