Fix SAST endpoint Issue
What does this MR do and why?
This MR fixes an Issue, that a renamed var coming from the BE was not renamed when it was parsed in template.
Renaming MR: !134968 (merged)
This merge request updates the
endpoint_sast
variable returned indiffs_tab_pane_data
helper method to return aboolean
instead of the path to the endpoint. The name of the variable was also changed tosast_report_available
.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Enable
sast_reports_in_inline_diff
- Make sure your running an ultimate license or your GDK (how to)
- Clone this repo: https://gitlab.com/jannik_lehmann/sast-inline-findings-example
- Recreate this MR for SAST & CodeQuality findings: jannik_lehmann/cq-and-sast-test!5 (diffs)
- Let the pipeline finish and the go checkout the diff page.
- Reload page multiple times to see polling in action.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Jannik Lehmann