Audit auditor role changes
What does this MR do and why?
This MR adds an audit event at eh instance level when a user is promoted or demoted as an auditor. Currently, we log this event for and admin user and this MR logs the event for auditor role changes.
By extending the audit logging to the 'Auditor' role, we can offer instance administrators a complete and transparent view of role changes within the platform. This will enhance security, accountability, and monitoring capabilities, ensuring that any changes to roles with access to sensitive data or functionalities are adequately tracked.
- Issue: #430235 (closed)
Screenshots or screen recordings
How to set up and validate locally
- In the GDK, navigate to
http://localhost:3000/admin/users/ANY_USER_NAME
- Edit the user and switch the role to auditor
- Verify the audit event in the instance level audit events page: http://localhost:3000/admin/audit_logs
- Switch the user back to regular user
- Verify the audit event in the instance level audit events page: http://localhost:3000/admin/audit_logs
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @s_shaik
added Support Team Contributions label
- A deleted user
added backend documentation featureaddition typefeature labels
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/administration/audit_event_streaming/audit_event_types.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @ghinfey
(UTC+0)
@dbalexandre
(UTC+0)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for ea7dc107expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 40 | 0 | 7 | 0 | 47 | ✅ | | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Govern | 48 | 0 | 0 | 0 | 48 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 201 | 0 | 10 | 0 | 211 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for ea7dc107expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 299 | 4 | 12 | 7 | 315 | ❌ | | Create | 146 | 0 | 25 | 0 | 171 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 465 | 4 | 41 | 7 | 510 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
added devopsgovern groupcompliance labels
added sectionsec label
mentioned in commit f76895c6
added 2 commits
- Resolved by Mario Celi
Hi @ghinfey
, kindly review this MR once you get a chance - Thank you!
requested review from @ghinfey
requested review from @mcelicalderonG
removed review request for @ghinfey
- Resolved by Mario Celi
@ghinfey
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
changed milestone to %16.6
- Resolved by Mario Celi
- Resolved by Mario Celi
enabled an automatic merge when the pipeline for 260633c1 succeeds
@terrichu, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 1cde5e88
mentioned in commit 10d973e9
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
removed documentation label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue gitlab-com/support/support-team-meta#5656 (closed)
mentioned in issue #430235 (closed)
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
mentioned in issue gitlab-com/support/support-team-meta#5668 (closed)
mentioned in merge request kubitus-project/kubitus-installer!2601 (merged)