Backfill default protection branch defaults in application setting

changed milestone to %16.6

added Next Up automation:ml automation:ml wrong backend devopsgovern groupcompliance missed:16.4 priority2 sectionsec typefeature workflowin dev + 1 deleted label

assigned to @harsimarsandhu

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 11d9416e

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
| Verify           | 32     | 0      | 0       | 0     | 32    | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Create           | 40     | 0      | 6       | 0     | 46    | ✅     |
| Govern           | 48     | 0      | 0       | 0     | 48    | ✅     |
| Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 201    | 0      | 9       | 0     | 210   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

changed milestone to %16.7

added missed:16.6 label

mentioned in merge request !136181 (merged)

marked this merge request as draft

mentioned in issue gitlab-org/govern/compliance/general#175

changed milestone to %16.8

added missed:16.7 label

changed milestone to %16.9

added missed:16.8 label

added 10433 commits

11d9416e...04cdda9b - 10431 commits from branch master
ad16c51e - Backfill default protection branch defaults in application setting
6474c884 - Update milestone

Compare with previous version

added database databasereview pending labels

	4 Warnings
	6474c884: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	95360f79: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	New migrations added but db/structure.sql wasn't updated Usually, when adding new migrations, db/structure.sql should be updated too (unless the migration isn't changing the DB schema and isn't the most recent one).
	Migration Timestamp Out of Date The following migrations have timestamps that are over three weeks old: db/migrate/20231108081209_backfill_branch_protection_application_setting.rb Please double check the timestamps and update them if possible. Why does this matter?

	1 Message
	This merge request adds or changes files that require a review from the Database team.

This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
Prepare your MR for database review according to the docs.
Assign and mention the database reviewer suggested by Reviewer Roulette.

The following files require a review from the Database team:

db/migrate/20231108081209_backfill_branch_protection_application_setting.rb
db/schema_migrations/20231108081209
spec/migrations/20231108081209_backfill_branch_protection_application_setting_spec.rb

Reviewer roulette

Category	Reviewer	Maintainer
database	`@nmilojevic1` (UTC+1, 4.5 hours behind author)	`@praba.m7n` (UTC+5.5, same timezone as author)

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

marked this merge request as ready

Database migrations (on the main database)

Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

Migration	Type	Total runtime	Result	DB size change
20231108081209 - BackfillBranchProtectionApplicationSetting	Regular	2.9 s		+0.00 B

Runtime Histogram for all migrations

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	4
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Migration: 20231108081209 - BackfillBranchProtectionApplicationSetting

Type: Regular
Duration: 2.9 s
Database size change: +0.00 B

Calls

Total Time

Max Time

Mean Time

Rows

Query

1

1.0 ms

1

SELECT "application_settings".*
  FROM "application_settings"  ORDER BY "application_settings"."id" ASC
  LIMIT $1

1

1.0 ms

1

SELECT "feature_gates"."key", "feature_gates"."value"  FROM "feature_gates"  WHERE "feature_gates"."feature_key" = $1

2

0.0 ms

2

SELECT pg_backend_pid()

Histogram for BackfillBranchProtectionApplicationSetting

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	4
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Other information

No other migrations pending on GitLab.com

Clone details

Clone ID	Clone Created At	Clone Data Timestamp	Expected Removal Time
`database-testing-2804940-12670156-main`	2024-01-30T09:12:41Z	2024-01-30T08:08:56Z	2024-01-30 21:16:53 +0000
`database-testing-2804940-12670156-ci`	2024-01-30T09:12:40Z	2024-01-30T08:45:41Z	2024-01-30 21:16:53 +0000

Job artifacts

Database migrations (on the ci database)

Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

Migration	Type	Total runtime	Result	DB size change
20231108081209 - BackfillBranchProtectionApplicationSetting	Regular	2.7 s		+0.00 B

Runtime Histogram for all migrations

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	2
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Migration: 20231108081209 - BackfillBranchProtectionApplicationSetting

Type: Regular
Duration: 2.7 s
Database size change: +0.00 B

Calls	Total Time	Max Time	Mean Time	Rows	Query
2	0.0 ms	0.0 ms	0.0 ms	2	SELECT pg_backend_pid()

Histogram for BackfillBranchProtectionApplicationSetting

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	2
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Other information

No other migrations pending on GitLab.com

Clone details

Clone ID	Clone Created At	Clone Data Timestamp	Expected Removal Time
`database-testing-2804940-12670156-main`	2024-01-30T09:12:41Z	2024-01-30T08:08:56Z	2024-01-30 21:16:53 +0000
`database-testing-2804940-12670156-ci`	2024-01-30T09:12:40Z	2024-01-30T08:45:41Z	2024-01-30 21:16:53 +0000

Job artifacts

Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic

added database-testing-automation label

We pushed the wrong values here !127296 (diffs) so this MR just rectifies those values.

@vyaklushin as you have the context of this could you please do the initial backend review?

requested review from @vyaklushin

approved this merge request

removed review request for @vyaklushin

@vyaklushin, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

added pipeline:mr-approved label

requested review from @nmilojevic1

approved this merge request

added databasereviewed label and removed databasereview pending label

requested review from @praba.m7n and removed review request for @nmilojevic1

added 1 commit

3ddeb06e - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

reset approvals from @vyaklushin and @nmilojevic1 by pushing to the branch

added 1 commit

95360f79 - Remove comments

Compare with previous version

requested review from @praba.m7n

resolved all threads

enabled an automatic merge when all merge checks for 95360f79 pass

approved this merge request

added databaseapproved label and removed databasereviewed label

removed review request for @praba.m7n

merged

Hello @harsimarsandhu

The database team is looking for ways to improve the database review process and we would love your help!

If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

@gitlab-org/database-team

And someone will be by shortly!

Thanks for your help!

This message was generated automatically. You're welcome to improve it.

mentioned in commit 2b5108df

mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#5196 (closed)

added workflowstaging-canary label and removed workflowin dev label

Backfill default protection branch defaults in application setting

What does this MR do and why?

Screenshots or screen recordings

How to set up and validate locally

MR acceptance checklist

Activity

Allure report

Reviewer roulette

Database migrations (on the main database)

Migration: 20231108081209 - BackfillBranchProtectionApplicationSetting

Other information

Database migrations (on the ci database)

Migration: 20231108081209 - BackfillBranchProtectionApplicationSetting

Other information

Backfill default protection branch defaults in application setting

What does this MR do and why?

Screenshots or screen recordings

How to set up and validate locally

MR acceptance checklist

Merge request reports

Activity

Allure report

Reviewer roulette

Database migrations (on the main database)

Migration: 20231108081209 - BackfillBranchProtectionApplicationSetting

Other information

Database migrations (on the ci database)

Migration: 20231108081209 - BackfillBranchProtectionApplicationSetting

Other information