Vueify default_membership_role_dropdown and add custom roles
What does this MR do and why?
This vueifies the default_membership_role_dropdown selector and allows for custom roles to be selected and saved to SAML settings.
Issue: #417285 (closed) (Frontend part)
Screenshots or screen recordings
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
- Enable group SAML
gdk config set omniauth.group_saml.enabled true && gdk reconfigure && gdk restart rails-web - Create a group with Ultimate license
- Go to http://localhost:3000/groups/${new_group}/-/settings/roles_and_permissions and create a custom role
- Go to http://localhost:3000/groups/${new_group}/-/saml, fill in the required form fields and select the custom role
- Reload the page and verify the custom role has been saved
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.6
assigned to @alexbuijs
Allure report
allure-report-publishergenerated test report!e2e-test-on-gdk:
expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Create | 40 | 0 | 7 | 0 | 47 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 214 | 0 | 10 | 0 | 224 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+e2e-package-and-test:
expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Package | 225 | 1 | 17 | 0 | 243 | ❌ | | Create | 543 | 0 | 67 | 0 | 610 | ✅ | | Fulfillment | 8 | 0 | 69 | 0 | 77 | ✅ | | Verify | 137 | 1 | 27 | 0 | 165 | ❌ | | Govern | 293 | 5 | 20 | 2 | 318 | ❌ | | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | | Plan | 249 | 0 | 10 | 0 | 259 | ✅ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 7 | 0 | 0 | 0 | 7 | ✅ | | Manage | 40 | 1 | 9 | 14 | 50 | ❌ | | Configure | 1 | 0 | 9 | 0 | 10 | ✅ | | Monitor | 39 | 0 | 7 | 0 | 46 | ✅ | | Data Stores | 119 | 0 | 1 | 2 | 120 | ❗ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Release | 15 | 0 | 3 | 0 | 18 | ✅ | | Secure | 6 | 0 | 3 | 0 | 9 | ✅ | | Framework sanity | 0 | 0 | 5 | 0 | 5 | ➖ | | ModelOps | 0 | 0 | 6 | 0 | 6 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 1692 | 8 | 260 | 18 | 1960 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+e2e-review-qa:
expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 2 | 0 | 10 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 5 | 0 | 25 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+Edited by Ghost Useradded 555 commits
- 8ad64e8c...e79da5c1 - 545 earlier commits
- 0c232d40 - Merge branch 'alvin-master-patch-478b' into 'master'
- 6dace648 - Allow Jira organization admins to setup group links
- 159f268d - Merge branch 'ft/jira-add-org-admins-support' into 'master'
- 1a5f2786 - Remove flux custom logic
- 1eb25671 - Merge branch '430324-remove-default-logic-for-flux-resource-fetch' into 'master'
- 82ca998e - Merge branch 'nd/move-explain-code-to-vertex' into 'master'
- d5fb869d - Move SSH codes troubleshooting to docs
- a89fced8 - Merge branch 'spt-5114' into 'master'
- abae5e36 - Add member_role_id to saml_providers
- ef93b602 - Add saving a custom role to SAML providers
Toggle commit list- A deleted user
added database databasereview pending labels
4 Warnings 
d8b1f9ea: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request contains lines with testid selectors. Please ensure e2e:package-and-testjob is run.This merge request contains deprecated data-qa-selector attribute. Please use data-testid attribute instead. Deprecated
testidselectorsThe following changed lines in this MR contain
testidselectors:ee/app/assets/javascripts/saml_providers/saml_membership_role_selector/components/saml_membership_role_selector.vue+ data-testid="selected-standard-role" + data-testid="selected-custom-role" + data-testid="default-membership-role-dropdown"If the
e2e:package-and-testjob in theqastage has run automatically, please ensure the tests are passing. If the job has not run, please start thetrigger-omnibus-and-follow-up-e2ejob in theqastage and ensure the tests infollow-up-e2e:package-and-test-eepipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Deprecated
data-qa-selectorselectorsThe following lines in this MR contain deprecated
data-qa-selectorselectors:ee/app/views/groups/saml_providers/_form.html.haml- = f.select :default_membership_role, options_for_select(group.access_level_roles, saml_provider.default_membership_role), {}, class: 'form-control', data: { qa_selector: 'default_membership_role_dropdown' }Please ensure all deprecated data-qa-selector attributes are replaced with data-testid attributes in accordance with our Testing Guide.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @arpitgogia
(UTC+5.5, 4.5 hours ahead of author)
@pedropombeiro (UTC+1, same timezone as author)
frontend @slashmanov (UTC+4, 3 hours ahead of author)
@eduardosanz (UTC+1, same timezone as author)
QA @john.mcdonnell (UTC+0, 1 hour behind author)
Maintainer review is optional for QA Please check reviewer's status!
-
Reviewer is available!
-
Reviewer is unavailable!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by Ghost User- A deleted user
added Data WarehouseImpact Check label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@4ad170f8
mentioned in issue #431326
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a444a9f9 and 1da99658
Entrypoint / Name Size before Size after Diff Diff in percent average 4.06 MB 4.06 MB - 0.0 % mainChunk 3.05 MB 3.05 MB - 0.0 % 
Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.saml_providers 301.58 KB 430.01 KB +128.42 KB 42.6 % pages.groups.saml_providers.saml_members.store 301.59 KB 430.02 KB +128.42 KB 42.6 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert,@markrian,@ohoralor@pgascouvaillancourt) for review, if you are unsure about the size increase.Note: We do not have exact data for a444a9f9. So we have used data from: 84f6e46c.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
added 274 commits
-
ef7d2c33...651e6a01 - 272 commits from branch
master - 4ca5d30f - Add member_role_id to saml_providers
- be421665 - Add saving a custom role to SAML providers
-
ef7d2c33...651e6a01 - 272 commits from branch
added 205 commits
-
be421665...5174e399 - 203 commits from branch
master - 7d3dd388 - Add member_role_id to saml_providers
- 673cbc60 - Add saving a custom role to SAML providers
-
be421665...5174e399 - 203 commits from branch
