Update policy setting default value
What does this MR do and why?
Update policy setting default value
- the default value for the require password for approval settings has been updated from true to false as per the epic description
Changelog: changed
EE: true
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Scenrio | Before | After |
---|---|---|
setting | ![]() |
![]() |
yaml | ![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Upload a GitLab Ultimate license
- Navigate to a project => Secure => Policies => New policy => Scan Result Policy => Select "Any merge request" type
- Verify that the
Require password for approval
setting is defaulted tofalse
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #418765 (closed)
Merge request reports
Activity
changed milestone to %16.6
assigned to @aturinske
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
1 Warning ⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend @minahilnichols
(UTC-4, 3 hours ahead of author)
@jerasmus
(UTC+1, 8 hours ahead of author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by Ghost User- Resolved by Artur Fedorov
@arfedoro can you review this small MR? Thanks
I think it is small enough and straightforward enough to merge with only on review as well. WDYT?
requested review from @arfedoro
mentioned in epic &9696 (closed)
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 0157fbcb and 1b7291bf
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.11 MB 4.11 MB - 0.0 % mainChunk 3.06 MB 3.06 MB - 0.0 %
Note: We do not have exact data for 0157fbcb. So we have used data from: 84e8d539.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
❗ test report for 1b7291bfexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 40 | 0 | 6 | 0 | 46 | ✅ | | Verify | 32 | 0 | 0 | 1 | 32 | ❗ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 48 | 0 | 0 | 0 | 48 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 201 | 0 | 9 | 1 | 210 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
❌ test report for 1b7291bfexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 302 | 1 | 12 | 4 | 315 | ❌ | | Create | 146 | 0 | 23 | 0 | 169 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 468 | 1 | 39 | 4 | 508 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded pipeline:mr-approved label
enabled an automatic merge when the pipeline for 31391968 succeeds
mentioned in commit c9d65592
added workflowcanary label and removed workflowin review label